r628 - x86/trunk/packages/kbd

Alexander E. Patrakov patrakov at ums.usu.ru
Fri Sep 9 05:34:00 PDT 2005


jhuntwork at linuxfromscratch.org wrote:

> +ifeq ($(ARCH),sparc)
> +	@cd .. ; wget $(URL-$(PATCH2))
> +	@patch -Np1 -i ../$(PATCH2)
> +endif

Isn't it cleaner to make stage2 depend on this patch unconditionally, 
thus providing SHA1 sum checking at the cost of several kilobytes of 
unneeded download for x86? Or even without this download (untested):

STAGE2-DEPS = $(FILE) $(BELARUSIAN_FILE) $(PATCH1)
ifeq ($(ARCH),sparc)
STAGE2-DEPS += $(PATCH2)
endif

...
stage2: Makefile $(STAGE2-DEPS)
... stuff with $(PATCH1) and $(BELARUSIAN_FILE) ...
ifeq ($(ARCH),sparc)
	@patch -Np1 -i ../$(PATCH2)
endif
...

-- 
Alexander E. Patrakov



More information about the livecd mailing list