Hopefully Someone Will Check and Comment on My Logic [OT Maybe?]

Dan McGhee beesnees62 at att.net
Sat Mar 12 17:11:37 PST 2011


On 03/12/2011 06:47 PM, Aleksandar Kuktin wrote:
>> On Sat, 12 Mar 2011 18:00:56 -0600
>> Dan McGhee<beesnees62 at att.net>  wrote:
>>
>>
>> [snip]
>>
>> Following is the script from the "variable definition" through the
>> logic tests.  I've eliminated all the "extra" stuff.
>>
>> [snip]
>>
>> # This one recovers from a failed install
>> if [ -e $logdir/make-`echo $package`.log ]&&  \
>> [ ! -e $HOME/$package-files.list ]; then
>>
>> [snip]
>>
>> I've removed a lot of stuff in the script trying to make things
>> relevant and specific to only the question.  Please feel free to ask
>> for additional info.
>>
>> [snip]
>>
Thank you, Aleksandar.
>> Well... DOES the script add all the logfiles it is supposed to add?
>> Are you /sure/? Have you checked?
Yes, yes and yes.
> The tests look kosher, as far as that matters, but I would turn my
> attention to the creation of logfiles.
>
> Other than that, my money is on the `echo $package` substitutions.
> If ${package} has a space in it, that could break it.
> You can fix this by doing ''[ -e "${logdir}/make-${package}.log" ]''.
This is what I was hoping to hear--that the logic is sound,but that 
there might be a problem in the construct. I've shied away from ( ) and 
{} in $ xxx statements because I'm really shaky on what they mean. I've 
also never seen the ' ' [ ] ' ' construct. I use the Advanced Bash 
Scripting Guide as my reference. Thank you for your feedback. I'll play 
with this.
> Take a small package (gzip?), and build it in such a way that it breaks
> at various points, then inspect the relevant directories to see what is
> there and what is not.
I've done this with GDBM by adding `exit 1` at various points. The 
results are as I have described in my first post.

I appreciate your input. We'll see what happens.

Dan



More information about the lfs-support mailing list