r1596 - in trunk/BOOK: chapter01 chapter05 chapter06

robert at linuxfromscratch.org robert at linuxfromscratch.org
Sat Nov 20 19:31:24 PST 2010


Author: robert
Date: 2010-11-20 20:31:20 -0700 (Sat, 20 Nov 2010)
New Revision: 1596

Modified:
   trunk/BOOK/chapter01/changelog.xml
   trunk/BOOK/chapter05/patch.xml
   trunk/BOOK/chapter06/patch.xml
Log:
Build Patch with -no-fatal-warnings.

Modified: trunk/BOOK/chapter01/changelog.xml
===================================================================
--- trunk/BOOK/chapter01/changelog.xml	2010-11-21 03:03:40 UTC (rev 1595)
+++ trunk/BOOK/chapter01/changelog.xml	2010-11-21 03:31:20 UTC (rev 1596)
@@ -41,6 +41,19 @@
       <para>2010-11-20</para>
       <itemizedlist>
         <listitem>
+          <para>[robert] - Build Patch with -no-fatal-warnings. The Patch
+          developers rejected the old mkstemp patch, and it alters the behavior
+          of Patch enough to break the test suite. The developers also consider
+          their use of mktemp safe.
+          </para>
+        </listitem>
+      </itemizedlist>
+    </listitem>
+
+    <listitem>
+      <para>2010-11-20</para>
+      <itemizedlist>
+        <listitem>
           <para>[robert] - Bump to bash fixes 3 patch.
           </para>
         </listitem>

Modified: trunk/BOOK/chapter05/patch.xml
===================================================================
--- trunk/BOOK/chapter05/patch.xml	2010-11-21 03:03:40 UTC (rev 1595)
+++ trunk/BOOK/chapter05/patch.xml	2010-11-21 03:31:20 UTC (rev 1596)
@@ -45,8 +45,15 @@
 
     <para>Prepare Patch for compilation:</para>
 
-<screen><userinput remap="configure">./configure --prefix=/tools</userinput></screen>
+<screen><userinput remap="configure">LDFLAGS="-no-fatal-warnings" ./configure --prefix=/tools</userinput></screen>
 
+    <para>The <envar>LDFLAGS="-no-fatal-warnings"</envar> environment variable
+    is needed here because this package uses the <function>mktemp</function>
+    function, which would normally cause our compiler to exit with an error.
+    The Patch developers consider the use of <function>mktemp</function> here
+    to be safe, and therefore have not made an effort to replace it with the
+    <function>mkstemp</function> function.</para>
+
     <para>Compile the package:</para>
 
 <screen><userinput remap="make">make</userinput></screen>

Modified: trunk/BOOK/chapter06/patch.xml
===================================================================
--- trunk/BOOK/chapter06/patch.xml	2010-11-21 03:03:40 UTC (rev 1595)
+++ trunk/BOOK/chapter06/patch.xml	2010-11-21 03:31:20 UTC (rev 1596)
@@ -49,7 +49,7 @@
 
     <para>Prepare Patch for compilation:</para>
 
-<screen><userinput remap="configure">./configure --prefix=/usr</userinput></screen>
+<screen><userinput remap="configure">LDFLAGS="-no-fatal-warnings" ./configure --prefix=/usr</userinput></screen>
 
     <para>Compile the package:</para>
 




More information about the hlfs-book mailing list