From kon at iki.fi Wed Jan 2 16:25:43 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Thu, 03 Jan 2008 01:25:43 +0200 Subject: [elinks-dev] [patch] locale-aware date format for ftp and file In-Reply-To: <20071216110329.GA16279@stranger.qboosh.pl> References: <20071216110329.GA16279@stranger.qboosh.pl> Message-ID: <87ejczolmw.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080103/0e64ac08/attachment.bin From giridhar at appaji.net Thu Jan 3 20:18:06 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Fri, 4 Jan 2008 08:48:06 +0530 Subject: [elinks-dev] bugzilla.elinks.or.cz password reset/change problems Message-ID: <20080104031805.GB3832@loktak> Hi, I signed up with bugzilla.elinks.or.cz to report and comment on bugs. However, even though I am able to with the password emailed to me, I am not able to change it (Incorrect old password error) and I am unable to rest the password via the link sent when I request for resetting the password (link expired). Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080104/e3a447c8/attachment.bin From kon at iki.fi Sat Jan 5 03:59:54 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sat, 05 Jan 2008 12:59:54 +0200 Subject: [elinks-dev] bugzilla.elinks.or.cz password reset/change problems In-Reply-To: <20080104031805.GB3832@loktak> References: <20080104031805.GB3832@loktak> Message-ID: <87ejcwfsgl.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080105/71e77da2/attachment.bin From kon at iki.fi Sun Jan 6 09:14:03 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sun, 06 Jan 2008 18:14:03 +0200 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <20080102130913.GD4317@loktak.hq.netapp.com> References: <20080102130913.GD4317@loktak.hq.netapp.com> Message-ID: <87bq7zdj90.fsf@Astalo.kon.iki.fi> http://mentors.debian.net/debian/pool/main/e/elinks/elinks_0.11.3-1.diff.gz adds to debian/changelog: + * Acknowledge bugs fixed via NMU + + Escape ' while saving keybinding for ' (Closes: #315550) + + LUA 5 compatible example in hooks.lua works now (Closes: #255871) Those were both fixed in or before 0.11.1-1, so I don't think NMUs had anything to do with them. + + Patch 01_asciidoc-escape-FTBFS.diff: Escape characters for asciidoc + conversion (prevents FTBFS in make all-docs) + + Patch 01_asciidoc-escape-FTBFS.diff: Point bugs URL to debian.org and + remove FSSTND dir in setup.h etc. The second one should be 02_setup-bugs-FSSTND.diff. + + Patch 05_257762-transparency-off.diff: Turn terminal transparency off + by default. Thanks Kalle Olavi Niemitalo for the fix + (Closes: #257762) Petr Baudis made the change, I only reported it to the Debian bug. + + Patch 06_elinks.conf-parse-error.diff: create elinks-lite.conf, set + config.saving_style=3 and comment options that are not valid. I think it would be better to ship an empty /etc/elinks.conf and make any Debian-specific changes to the source code instead. That way, when we change the defaults in later versions, you wouldn't have to change /etc/elinks.conf, and users who have edited /etc/elinks.conf wouldn't have to merge the changes. In commit 2c576cd1d65a75e07d78445d96a85b464f919228, I already removed contrib/elinks.conf from 0.12.GIT for this reason. ELinks 0.11.3 had a regression that has been fixed in 0.11.3.GIT. From NEWS: * fix query parsing in file: URIs for local CGI (was broken in 0.11.3) This was fixed in commit e96665134ae9b5106fe0d5c30d445212d970e91b. If you're already picking patches from GIT, it might make sense to apply that commit too. Although really, there are so many fixes in 0.11.3.GIT that we should just release 0.11.4. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080106/ab00f79d/attachment.bin From giridhar at appaji.net Sun Jan 6 12:06:42 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Mon, 7 Jan 2008 00:36:42 +0530 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <87bq7zdj90.fsf@Astalo.kon.iki.fi> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> Message-ID: <20080106190640.GH4718@loktak> On 08/01/06 18:14 +0200, Kalle Olavi Niemitalo said ... > + + Escape ' while saving keybinding for ' (Closes: #315550) > + + LUA 5 compatible example in hooks.lua works now (Closes: #255871) > > Those were both fixed in or before 0.11.1-1, so I don't think > NMUs had anything to do with them. Indeed. I've marked these done and removed them from the dch. > + + Patch 01_asciidoc-escape-FTBFS.diff: Point bugs URL to debian.org and > + remove FSSTND dir in setup.h etc. > > The second one should be 02_setup-bugs-FSSTND.diff. Yes, thank you. I've changed that now. > + + Patch 05_257762-transparency-off.diff: Turn terminal transparency off > + by default. Thanks Kalle Olavi Niemitalo for the fix > + (Closes: #257762) > > Petr Baudis made the change, I only reported it to the Debian bug. I've credited Petr Baudis. > * fix query parsing in file: URIs for local CGI (was broken in 0.11.3) > > This was fixed in commit e96665134ae9b5106fe0d5c30d445212d970e91b. > If you're already picking patches from GIT, it might make sense > to apply that commit too. I've picked that fix as 07_local-CGI-query-fix.diff > Although really, there are so many fixes in 0.11.3.GIT that we > should just release 0.11.4. Would you also please consider removing the debian/ directory from released tarballs of elinks? It makes it very difficult for people to read the diff.tar.gz and maintaining it is outside debian is quite difficult. I will raise a bug for this anyway. Thanks, Giridhar PS: I am subscribed to elinks-dev in digest mode, but my previous mail to elinks-dev (in response to your password reset mail) was rejected as spam. -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080107/3ee496fd/attachment.bin From kon at iki.fi Sun Jan 6 13:45:54 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sun, 06 Jan 2008 22:45:54 +0200 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <20080106190640.GH4718@loktak> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> <20080106190640.GH4718@loktak> Message-ID: <877iimel8d.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080106/2781df20/attachment.bin From fonseca at diku.dk Mon Jan 14 05:02:19 2008 From: fonseca at diku.dk (Jonas Fonseca) Date: Mon, 14 Jan 2008 13:02:19 +0100 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <87bq7zdj90.fsf@Astalo.kon.iki.fi> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> Message-ID: <20080114120218.GB32746@diku.dk> Kalle Olavi Niemitalo wrote Sun, Jan 06, 2008: > Although really, there are so many fixes in 0.11.3.GIT that we > should just release 0.11.4. ... and you have done a lot of work to port things back to the 0.11 branch. I would like to show my gratitude, if it even makes sense, by promising to do my part to have the 0.11.4 release done by the end of January. Do you or anybody else have any comments on outstanding issues for this release? Also, any stuff needed by debian? (I didn't check if you also moved the debian/ directory in 0.11.GIT) [ It will take me a few days before I can get back into the ELinks-loop of IRC and so on, since I am in the process of migrating to a new machine. ] -- Jonas Fonseca From kon at iki.fi Mon Jan 14 15:36:25 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Tue, 15 Jan 2008 00:36:25 +0200 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <20080114120218.GB32746@diku.dk> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> <20080114120218.GB32746@diku.dk> Message-ID: <87prw4rq52.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080115/50535776/attachment.bin From giridhar at appaji.net Fri Jan 18 01:31:03 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Fri, 18 Jan 2008 14:01:03 +0530 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <87prw4rq52.fsf@Astalo.kon.iki.fi> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> <20080114120218.GB32746@diku.dk> <87prw4rq52.fsf@Astalo.kon.iki.fi> Message-ID: <20080118083102.GB4295@loktak.hq.netapp.com> On 08/01/15 00:36 +0200, Kalle Olavi Niemitalo said ... > Jonas Fonseca writes: > > > Do you or anybody else have any comments on outstanding issues > > for this release? > > There are several bugs that have been fixed in 0.12 or 0.13 and > should perhaps be backported: [snip...] > However, the important ones look rather involved and I'm not > certain I could correctly backport them on the first attempt, > so it would be better to release 0.11.4 first and worry about > those bugs after the release when there is time to test the > fixes properly. And in case you feel that making a new release is a lot of work and would like some of the above important bugs to make it to 0.11.4, I can pick fixes leading up to 0.11.4 (the ones that are already in 0.11 GIT) and include them as patches in the next revision of Debian ELinks. We already include the following in debian/patches/ 5210d97c3756b04f1cf5c27fde8ed342ac756a0d 01_asciidoc7compatible.diff 14588b9455583096ddeb54b0541bfc230a2a2451 04_380347-entity_cache-overflow.diff 6390c327aa61b83776a45512ca3db08f04fe4a5d 05_257762-transparency-off.diff e96665134ae9b5106fe0d5c30d445212d970e91b 07_local-CGI-query-fix.diff But I would like to pick only those that you consider important or the ones that are requested by Debian users (and easy to merge). > > Also, any stuff needed by debian? (I didn't check if > > you also moved the debian/ directory in 0.11.GIT) > > For Debian, there is mainly: > > 988 min - Please remove debian directory and build generated files > > I've moved debian/ to contrib/debian/ in 0.11, 0.12, and 0.13, > so that part should be okay now. > You can remove the generated files by hand I guess, > but fixing the bug ought to include updating mkdist. Right now, contents of elinks_0.11.3.orig.tar.gz are different from elinks-0.11.3.tar.bz2. The debian/, po/*.gmo, po/.deps, config.log, config.status and features.log have been removed. But 988 is a nice to have. And to make sure that users know what they are getting, there is a get-orig-source target in the debian/rules file. Giridhar PS: http://git.debian.org/?p=collab-maint/elinks.git;a=summary for Debian ELinks git repository. -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080118/7adc0921/attachment.bin From kon at iki.fi Sat Jan 19 01:00:41 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sat, 19 Jan 2008 10:00:41 +0200 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <20080118083102.GB4295@loktak.hq.netapp.com> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> <20080114120218.GB32746@diku.dk> <87prw4rq52.fsf@Astalo.kon.iki.fi> <20080118083102.GB4295@loktak.hq.netapp.com> Message-ID: <87sl0ub5xy.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080119/3d7711a2/attachment.bin From kon at iki.fi Sat Jan 19 14:52:21 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sat, 19 Jan 2008 23:52:21 +0200 Subject: [elinks-dev] unrecognized options in elinks.conf (was: Serious bug in the FSP code) In-Reply-To: <20080119125556.GA16285@diku.dk> References: <20080118202540.GA4600@pldmachine> <87wsq6b6lc.fsf@Astalo.kon.iki.fi> <87k5m6b4pk.fsf@Astalo.kon.iki.fi> <20080119104150.GA5588@pldmachine> <20080119125556.GA16285@diku.dk> Message-ID: <878x2lbi0a.fsf_-_@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080119/81a51898/attachment.bin From giridhar at appaji.net Sun Jan 20 00:07:54 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Sun, 20 Jan 2008 12:37:54 +0530 Subject: [elinks-dev] upcoming Debian ELinks 0.11.3-1; release 0.11.4? In-Reply-To: <87sl0ub5xy.fsf@Astalo.kon.iki.fi> References: <20080102130913.GD4317@loktak.hq.netapp.com> <87bq7zdj90.fsf@Astalo.kon.iki.fi> <20080114120218.GB32746@diku.dk> <87prw4rq52.fsf@Astalo.kon.iki.fi> <20080118083102.GB4295@loktak.hq.netapp.com> <87sl0ub5xy.fsf@Astalo.kon.iki.fi> Message-ID: <20080120070751.GC21720@loktak.appaji.net> On 08/01/19 10:00 +0200, Kalle Olavi Niemitalo said ... > Y Giridhar Appaji Nag writes: > > > elinks-0.11.3.tar.bz2. The debian/, po/*.gmo, po/.deps, config.log, > > config.status and features.log have been removed. But 988 is a nice to > > We should keep po/*.gmo in elinks-*.tar.gz though, so that users > can install ELinks even if they don't have a msgfmt program. > I see you didn't ask for those to be removed in bug 988, either. That is right. I noticed it being mentioned in po/README (or some place else) so did not request removal of *.gmo. As an aside, I feel that people who tend to use po files will have msgfmt (and those using distribution packages don't need it anyway). > Why do you remove po/.deps? It's an empty directory so it > shouldn't cause any problems with patching. No strong reason in particular (but that one kinda goes with the .gmo files so I removed it). Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080120/c212ad17/attachment.bin From fonseca at diku.dk Sun Jan 20 02:45:48 2008 From: fonseca at diku.dk (Jonas Fonseca) Date: Sun, 20 Jan 2008 10:45:48 +0100 Subject: [elinks-dev] unrecognized options in elinks.conf (was: Serious bug in the FSP code) In-Reply-To: <878x2lbi0a.fsf_-_@Astalo.kon.iki.fi> References: <20080118202540.GA4600@pldmachine> <87wsq6b6lc.fsf@Astalo.kon.iki.fi> <87k5m6b4pk.fsf@Astalo.kon.iki.fi> <20080119104150.GA5588@pldmachine> <20080119125556.GA16285@diku.dk> <878x2lbi0a.fsf_-_@Astalo.kon.iki.fi> Message-ID: <20080120094548.GA30469@diku.dk> Kalle Olavi Niemitalo wrote Sat, Jan 19, 2008: > Moving to elinks-dev. > > Jonas Fonseca writes: > > > Sounds reasonable, however, I don't particularly like that you simply > > drop an option, since it will lead to warning messages. > > Are those warning messages useful, or could we just remove them? > They also occur when I test ELinks builds configured with > different features. > > The warnings might be helpful to someone who modifies elinks.conf > with a text editor and isn't sure about the spelling, but I don't > know why that person wouldn't use the option manager. Anyway, we > could have an elinks --check-config that shows the warnings and > then exits and leaves them on the screen. Yeah, they are probably not generally useful besides for users and developers who should be knowing what they do. But it also feels a bit wrong to simply drop the warnings. With the option you propose, maybe the a single shorter warning message is acceptable: Warnings found while parsing /.../elinks.conf. Use the --check-config option to show all warnings. Perhaps shorter than that. -- Jonas Fonseca From kon at iki.fi Sun Jan 20 05:58:23 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sun, 20 Jan 2008 14:58:23 +0200 Subject: [elinks-dev] unrecognized options in elinks.conf In-Reply-To: <20080120094548.GA30469@diku.dk> References: <20080118202540.GA4600@pldmachine> <87wsq6b6lc.fsf@Astalo.kon.iki.fi> <87k5m6b4pk.fsf@Astalo.kon.iki.fi> <20080119104150.GA5588@pldmachine> <20080119125556.GA16285@diku.dk> <878x2lbi0a.fsf_-_@Astalo.kon.iki.fi> <20080120094548.GA30469@diku.dk> Message-ID: <87prvwac28.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080120/2dc50d1f/attachment.bin From kon at iki.fi Tue Jan 22 15:26:16 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Wed, 23 Jan 2008 00:26:16 +0200 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> Message-ID: <871w89bipj.fsf@Astalo.kon.iki.fi> Qingning Huo writes: > So what is the real reason of this bug, elinks > is somehow confused whether it is at foreground? The reason is that "fg" in Bash nowadays does not send SIGCONT to the job if Bash has seen from waitpid() that the job is already running. ELinks expects to receive this SIGCONT, in order to know when it should try to take control of the terminal again. This worked correctly in Bash 2.05 but has been broken since 2.05a. The following patch does not revert any change between 2.05 and 2.05a but fixes or works around the bug anyway. diff -up /var/tmp/Kalle/Debian/bash-3.1dfsg/bash/jobs.c.\~1\~ /var/tmp/Kalle/Debian/bash-3.1dfsg/bash/jobs.c --- /var/tmp/Kalle/Debian/bash-3.1dfsg/bash/jobs.c.~1~ 2008-01-23 00:16:33.000000000 +0200 +++ /var/tmp/Kalle/Debian/bash-3.1dfsg/bash/jobs.c 2008-01-23 00:17:55.000000000 +0200 @@ -2754,8 +2754,7 @@ start_job (job, foreground) else jobs[job]->flags &= ~J_FOREGROUND; - /* If the job is already running, then don't bother jump-starting it. */ - if (already_running == 0) + if (1) { jobs[job]->flags |= J_NOTIFIED; killpg (jobs[job]->pgrp, SIGCONT); -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080123/aafc705a/attachment.bin From kon at iki.fi Wed Jan 23 01:47:06 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Wed, 23 Jan 2008 10:47:06 +0200 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <871w89bipj.fsf@Astalo.kon.iki.fi> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> <871w89bipj.fsf@Astalo.kon.iki.fi> Message-ID: <87r6g99bed.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080123/a3fab00e/attachment.bin From giridhar at appaji.net Wed Jan 23 02:00:49 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Wed, 23 Jan 2008 14:30:49 +0530 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <87r6g99bed.fsf@Astalo.kon.iki.fi> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> <871w89bipj.fsf@Astalo.kon.iki.fi> <87r6g99bed.fsf@Astalo.kon.iki.fi> Message-ID: <20080123090048.GD3835@loktak.hq.netapp.com> On 08/01/23 10:47 +0200, Kalle Olavi Niemitalo said ... > Kalle Olavi Niemitalo writes: > > > This worked correctly in Bash 2.05 but has been broken since 2.05a. > > These shells are also OK: > > csh 20070713-1 > pdksh 5.2.14-21 > tcsh 6.14.00-7 > zsh 4.0.6-18 > zsh 4.3.4-dev-7-2 See also: http://bugs.debian.org/331409#57 Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080123/0b15e626/attachment.bin From giridhar at appaji.net Wed Jan 23 02:26:46 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Wed, 23 Jan 2008 14:56:46 +0530 Subject: [elinks-dev] 0.12 packages for Debian experimental Message-ID: <20080123092645.GG3835@loktak.hq.netapp.com> Hi, We (the Debian ELinks maintainers) were thinking about making packages of elinks 0.12 for experimental. Packages in experimental usually have upstream unstable features enabled for testing and they are not propagated to testing/stable. I would like to ask you which features you would want to see enabled in the 0.12 experimental packages and if you are OK with the additional bug reports that might flow in as a result. Cheers, Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080123/a360330d/attachment.bin From kon at iki.fi Wed Jan 23 14:28:18 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Wed, 23 Jan 2008 23:28:18 +0200 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <20080123090048.GD3835@loktak.hq.netapp.com> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> <871w89bipj.fsf@Astalo.kon.iki.fi> <87r6g99bed.fsf@Astalo.kon.iki.fi> <20080123090048.GD3835@loktak.hq.netapp.com> Message-ID: <8763xkdyfh.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080123/93e3befd/attachment.bin From giridhar at appaji.net Wed Jan 23 20:10:08 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Thu, 24 Jan 2008 08:40:08 +0530 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <8763xkdyfh.fsf@Astalo.kon.iki.fi> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> <871w89bipj.fsf@Astalo.kon.iki.fi> <87r6g99bed.fsf@Astalo.kon.iki.fi> <20080123090048.GD3835@loktak.hq.netapp.com> <8763xkdyfh.fsf@Astalo.kon.iki.fi> Message-ID: <20080124031007.GA3513@loktak.appaji.net> On 08/01/23 23:28 +0200, Kalle Olavi Niemitalo said ... > Y Giridhar Appaji Nag writes: > > > See also: http://bugs.debian.org/331409#57 > > Thank you for the pointer. However, I think it would be wrong > to reopen bug 331409 for the Bash-ELinks interaction, because > it was originally about a busy loop in Bash and that's not what > happens in bug 337159. > > What is the procedure for asking the Bash maintainer whether I am Cc:ing the bash PTS for a comment. > he considers the loss of SIGCONT a bug in Bash or in ELinks > (and if the latter, how else should ELinks be implemented)? Hi Matthias, can you please comment on this? From http://bugs.debian.org/337159#30 : The reason is that "fg" in Bash nowadays does not send SIGCONT to the job if Bash has seen from waitpid() that the job is already running. ELinks expects to receive this SIGCONT, in order to know when it should try to take control of the terminal again. This worked correctly in Bash 2.05 but has been broken since 2.05a. > I suppose I shouldn't just reassign bug 337159 to bash. We can do that at a later point. Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080124/23204c20/attachment.bin From giridhar at appaji.net Wed Jan 23 20:13:15 2008 From: giridhar at appaji.net (Y Giridhar Appaji Nag) Date: Thu, 24 Jan 2008 08:43:15 +0530 Subject: [elinks-dev] Bug#337159: elinks: Does not recover from CTRL-Z In-Reply-To: <20080124031007.GA3513@loktak.appaji.net> References: <20051030133505.GA6804@pumuki.org> <20051102230059.GK16512@pasky.or.cz> <20051114115142.GA2144@linuxdev3.dev.lanware.co.uk> <20051114121124.GL16061@pasky.or.cz> <20051114141029.GA5763@linuxdev3.dev.lanware.co.uk> <871w89bipj.fsf@Astalo.kon.iki.fi> <87r6g99bed.fsf@Astalo.kon.iki.fi> <20080123090048.GD3835@loktak.hq.netapp.com> <8763xkdyfh.fsf@Astalo.kon.iki.fi> <20080124031007.GA3513@loktak.appaji.net> Message-ID: <20080124031315.GB3513@loktak.appaji.net> Resending with a X-PTS-Approved header. On 08/01/23 23:28 +0200, Kalle Olavi Niemitalo said ... > Y Giridhar Appaji Nag writes: > > > See also: http://bugs.debian.org/331409#57 > > Thank you for the pointer. However, I think it would be wrong > to reopen bug 331409 for the Bash-ELinks interaction, because > it was originally about a busy loop in Bash and that's not what > happens in bug 337159. > > What is the procedure for asking the Bash maintainer whether I am Cc:ing the bash PTS for a comment. > he considers the loss of SIGCONT a bug in Bash or in ELinks > (and if the latter, how else should ELinks be implemented)? Hi Matthias, can you please comment on this? From http://bugs.debian.org/337159#30 : The reason is that "fg" in Bash nowadays does not send SIGCONT to the job if Bash has seen from waitpid() that the job is already running. ELinks expects to receive this SIGCONT, in order to know when it should try to take control of the terminal again. This worked correctly in Bash 2.05 but has been broken since 2.05a. > I suppose I shouldn't just reassign bug 337159 to bash. We can do that at a later point. Giridhar -- Y Giridhar Appaji Nag | http://www.appaji.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080124/fc769825/attachment.bin From kon at iki.fi Sat Jan 26 05:14:11 2008 From: kon at iki.fi (Kalle Olavi Niemitalo) Date: Sat, 26 Jan 2008 14:14:11 +0200 Subject: [elinks-dev] parse_bencoding_integer does not detect all overflows Message-ID: <87bq78okbw.fsf@Astalo.kon.iki.fi> A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 188 bytes Desc: not available Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080126/c22cba97/attachment.bin From fonseca at diku.dk Sat Jan 26 06:08:36 2008 From: fonseca at diku.dk (Jonas Fonseca) Date: Sat, 26 Jan 2008 14:08:36 +0100 Subject: [elinks-dev] parse_bencoding_integer does not detect all overflows In-Reply-To: <87bq78okbw.fsf@Astalo.kon.iki.fi> References: <87bq78okbw.fsf@Astalo.kon.iki.fi> Message-ID: <20080126130836.GA26959@diku.dk> Kalle Olavi Niemitalo wrote Sat, Jan 26, 2008: > So if the overflow check is necessary, it should be corrected. > If overflows can be assumed to wrap (C does not guarantee that), > then I think the following is correct and the simplest solution: > > > for (; pos < length && isdigit(string[pos]); pos++) { > off_t newint = integer * 10 + string[pos] - '0'; > > if (newint / 10 != integer) > return 0; /* overflow */ > integer = newint; > } > > OTOH, if overflows instead trap or saturate, then this won't work. I think the dectection is necessary and I like your correction. -- Jonas Fonseca