[elinks-dev] please don't git describe in 0.12

[Kalle Olavi Niemitalo]

In ELinks 0.11.3.GIT, there is:

commit 36730c3c8389e0f31248b9fab0a0cb16b5562f1e
Author: Jonas Fonseca <fonseca at diku.dk>
Date:   Tue Jan 22 13:21:29 2008 +0100

    Use git tools instead of cogito for getting the build ID

    The build ID now includes both last tagged version, commit generation
    since last tagged version, as well as the leading characters of the
    commit ID and a flag for dirty working tree.

Please do not apply this to ELinks 0.12.GIT.

Firstly, it appears to consider the working tree dirty whenever I
build ELinks outside the source directory.  That would be easy to
fix, though.

The more annoying problem is that git describe happily picks
whatever annotated tag is closest to the commit.  I make use of
many annotated tags that do not correspond to ELinks releases.
For example, git cat-file tag bug/755/att380:

| object 871a1befad3d9c37c59f228154d12fe37f594703
| type commit
| tag bug/755/att380
| tagger Kalle Olavi Niemitalo <Kalle at Astalo.kon.iki.fi> 1185882530 +0300
| 
| Attachment 380 of ELinks bug 755,
| "Crash when trying to load 401k.com login page"
| <http://bugzilla.elinks.cz/show_bug.cgi?id=755>
| <http://bugzilla.elinks.cz/attachment.cgi?id=380>

So, if I cherry-pick this change and I build ELinks, the About
screen displays something like "bug/755/att380-268-ge3e894a-dirty".
That is stupid because my bug/*/att* tags really stand for patches
rather than for the resulting trees.

With unreleased versions of Git, we could apparently use git
describe --match "elinks-*" to consider ELinks releases only.
But what should happen if the installed Git is older?

I think the real solution to this would be for Git to define
a way for .git/config to _exclude_ tags from git describe.
Then I could upgrade to the required version and set the option,
and ELinks would not have to care about Git versions or my tags.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20080229/f8de4c91/attachment.bin