[elinks-dev] FSP and passwords

[Jonas Fonseca]

Witold Filipczyk <witekfl at poczta.onet.pl> wrote Sat, Dec 09, 2006:
> Hey,

Hello Witold,

> Password protected directories doesn't work with the FSP code.
> get_uri_string(uri, URI_PASSWORD) simply doesn't work.

I have fixed this in add_uri_to_string() instead of the FSP protocol
backend, which seemed a little simpler.

Pushed as commit f90c07d54f6848025b82c0c2c9eab7663d240277.

> I don't know how to use branches, so I'm including the patch here:

Well, let me know if you want to know how to set up a branch in the
repository to hack on. If you use cogito it should be as easy as:

$ cg branch-add remote-my-branch git+ssh://[user+host]/srv/git/elinks.git#my-branch

# Check that the new branch is correct
$ cg branch-ls

# Make a new local branch called my-branch that will be based on the
# current origin branch
$ cg switch -r origin my-branch
$ edit / make / commit
# When you want to publish your changes
$ cg push remote-my-branch

# If you want to go back to the master branch use
$ cg switch master

# If you want to merge stuff from master into the my-branch and current
# have checked out the master branch (cg-status will tell you the
# current branch), first checkout the my-branch branch and then merge
# from master:
$ cg switch my-branch
$ cg merge master

Note, most of the above I wrote in the buffer without testing, but
passing --long-help to either cogito command should give you the
details.

> In directory listings, IMHO, this password should be added to base href,
> otherwise it must be added by hand for every followed link.

It would maybe make sense to use the protocol auth history for this. Do
you know if the FSP server is able to notify the client about
authentication being necessary?

> The same case is for smb2(not applied yet).

Sorry, I didn't really look at the code yet, and as I said I don't have
a good way to test it right now.

-- 
Jonas Fonseca