[elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event

[Jonas Fonseca]

Kalle Olavi Niemitalo <kon at iki.fi> wrote Sun, Aug 27, 2006:
> Jonas Fonseca <fonseca at diku.dk> writes:
> 
> >  - You indented the goto label in the first commit (e333fb37) and
> >    normally labels should not be indented.
> 
> Oops.  I see that's in doc/hacking.txt too.  I guess I'll have to
> configure Emacs to use a custom indentation style for ELinks code.

It's not a big deal. It would be better not to use goto at all. ;)

> >  - I don't seem to remember the introduction of is_utf16_surrogate()
> >    used in the second commit (be7526d0). Did you forgot to add
> >    intl/charset.h to the file commit list?
> 
> I added is_utf16_surrogate in commit 38fe5b72 aka be7526d0~2,
> "Define and use macros for handling UTF-16 surrogates."
> I typically commit a whole tree, rather than individual files.

Ok, sorry for the noise then.

-- 
Jonas Fonseca