From myself at ligesh.com  Tue Aug  1 00:19:08 2006
From: myself at ligesh.com (Ligesh)
Date: Tue, 1 Aug 2006 11:49:08 +0530
Subject: [elinks-dev] How to enable xterm cut and paste
Message-ID: <20060801061908.GA4320@lxlabs.com>


Hi folks,

 Elinks seems to disable the xterm cut and paste and uses its own mouse handling or something. How do I just enable the old simple xterm's paste-with-the-middle button feature?

 Thanks a lot.


From mdm0304 at ecu.edu  Tue Aug  1 00:21:32 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Tue, 1 Aug 2006 06:21:32 +0000
Subject: [elinks-dev] How to enable xterm cut and paste
In-Reply-To: <20060801061908.GA4320@lxlabs.com>
References: <20060801061908.GA4320@lxlabs.com>
Message-ID: <20060801062132.GA16750@FroodyComp.localdomain>

On Tue, Aug 01, 2006 at 11:49:08AM +0530, Ligesh wrote:
> 
> Hi folks,
> 
>  Elinks seems to disable the xterm cut and paste and uses its own mouse handling or something. How do I just enable the old simple xterm's paste-with-the-middle button feature?

Hold Shift down as you use the mouse. If that doesn't work, try holding
Ctrl down.

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From kon at iki.fi  Tue Aug  1 02:27:43 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Tue, 01 Aug 2006 11:27:43 +0300
Subject: [elinks-dev] [patch] terminal doc: itrm.in.sock == itrm.out.std in
 the master process.
In-Reply-To: <873bcnzdan.fsf@Astalo.kon.iki.fi>
References: <87hd17aqve.fsf@Astalo.kon.iki.fi>
	<873bcnzdan.fsf@Astalo.kon.iki.fi>
Message-ID: <877j1s508w.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 1082 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060801/e35e9807/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060801/e35e9807/attachment-0001.bin 

From kon at iki.fi  Tue Aug  1 12:00:05 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Tue, 01 Aug 2006 21:00:05 +0300
Subject: [elinks-dev] [patch] BFU: Fix cell count for forcibly wrapped lines.
Message-ID: <87r7001gm2.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 1417 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060801/ee41b64c/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060801/ee41b64c/attachment-0001.bin 

From fonseca at diku.dk  Wed Aug  2 17:07:10 2006
From: fonseca at diku.dk (Jonas Fonseca)
Date: Thu, 3 Aug 2006 01:07:10 +0200
Subject: [elinks-dev] how to post patches (was: [patch] terminal doc:
	Document struct itrm and related things.)
In-Reply-To: <87psfncw5e.fsf_-_@Astalo.kon.iki.fi>
References: <87hd17aqve.fsf@Astalo.kon.iki.fi> <20060729231153.GC10844@diku.dk>
	<87psfncw5e.fsf_-_@Astalo.kon.iki.fi>
Message-ID: <20060802230710.GB19766@diku.dk>

Kalle Olavi Niemitalo <kon at iki.fi> wrote Sun, Jul 30, 2006:
> Jonas Fonseca <fonseca at diku.dk> writes:
> 
> > The other "patch collections" in this thread I haven't looked into yet,
> > so I don't know whether they are a good idea. But the format chosen
> > makes it harder to make sense of the patches.

Hmm, I might have been a bit tired when I wrote this. It sounds like a
lame excuse for quitting half way through. :)

> Please describe your preferred format and your reasons for it.

The individual patches look very good. When reading through a patch
series a few notes about the whole thing is nice to have. Also, I
generally prefer one patch per mail, so you can easily move through the
series.

-- 
Jonas Fonseca


From kon at iki.fi  Thu Aug  3 17:21:07 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:07 +0300
Subject: [elinks-dev] [patch 0/5] UTF-8: Use UCS-4 in struct
	term_event_keyboard.
Message-ID: <87odv1z9r0.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/ad682116/attachment.bin 

From kon at iki.fi  Thu Aug  3 17:21:15 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:15 +0300
Subject: [elinks-dev] [patch 1/5] Define separate structs for events passed
 via the interlink socket.
In-Reply-To: <878xm51m1j.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
Message-ID: <87mzalz9qs.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 38714 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/5bef5e5d/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/5bef5e5d/attachment-0001.bin 

From kon at iki.fi  Thu Aug  3 17:21:25 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:25 +0300
Subject: [elinks-dev] [patch 2/5] Renumber special keys to negative values,
 making room for Unicode.
In-Reply-To: <878xm51m1j.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
Message-ID: <87lkq5z9qi.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 7160 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/71a765b0/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/71a765b0/attachment-0001.bin 

From kon at iki.fi  Thu Aug  3 17:21:37 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:37 +0300
Subject: [elinks-dev] [patch 3/5] #ifdef CONFIG_UTF_8,
 translate all terminal input via UCS-4.
In-Reply-To: <878xm51m1j.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
Message-ID: <87k65pz9q6.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 6308 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/45363b0e/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/45363b0e/attachment-0001.bin 

From kon at iki.fi  Thu Aug  3 17:21:47 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:47 +0300
Subject: [elinks-dev] [patch 4/5] terminal doc: The interlink protocol no
 longer uses struct term_event.
In-Reply-To: <878xm51m1j.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
Message-ID: <87irl9z9pw.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 1035 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/b7aa9230/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/b7aa9230/attachment-0001.bin 

From kon at iki.fi  Thu Aug  3 17:21:59 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 02:21:59 +0300
Subject: [elinks-dev] [patch 5/5] #ifdef CONFIG_UTF_8,
	term_event_keyboard.key is UCS-4.
In-Reply-To: <878xm51m1j.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
Message-ID: <87fygdz9pk.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 7613 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/d64b304f/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/d64b304f/attachment-0001.bin 

From mdm0304 at ecu.edu  Fri Aug  4 00:41:20 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Fri, 4 Aug 2006 06:41:20 +0000
Subject: [elinks-dev] [patch 2/5] Renumber special keys to negative values,
In-Reply-To: <87lkq5z9qi.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87lkq5z9qi.fsf@Astalo.kon.iki.fi>
Message-ID: <20060804064120.GA3649@FroodyComp.localdomain>

On Fri, Aug 04, 2006 at 02:21:25AM +0300, Kalle Olavi Niemitalo wrote:
> Renumber special keys to negative values, making room for Unicode.
[...]
> diff --git a/src/config/kbdbind.c b/src/config/kbdbind.c
> index 0e3996e..abc2809 100644
> --- a/src/config/kbdbind.c
> +++ b/src/config/kbdbind.c
> @@ -437,7 +437,7 @@ parse_keystroke(unsigned char *s, int ca
>  	}
>  
>  	kbd->key = read_key(s);
> -	return (kbd->key < 0) ? -1 : 0;
> +	return (kbd->key == KBD_UNDEF) ? -1 : 0;
>  }
>  
>  void
> @@ -449,7 +449,7 @@ add_keystroke_to_string(struct string *s
>  	struct key *key;
>  	const struct modifier *modp;
>  
> -	if (kbd->key < 0) return;
> +	if (kbd->key == KBD_UNDEF) return;
>  
>  	for (modp = modifiers; modp->name_and_dash != NULL; ++modp) {
>  		if (kbd->modifier & modp->bitmask)

Maybe this should be a separate patch.

> diff --git a/src/terminal/kbd.c b/src/terminal/kbd.c
> index a2a8827..07fd305 100644
> --- a/src/terminal/kbd.c
> +++ b/src/terminal/kbd.c
[...]
> @@ -770,10 +770,9 @@ #endif /* CONFIG_MOUSE */
>  		break;
>  	}
>  
> -	/* The event might have been changed to a mouse event */
> -	if (ev->ev == EVENT_KBD && kbd.key != KBD_UNDEF) {
> -		copy_struct(&ev->info.keyboard, &kbd);
> -	}
> +	/* KBD_UNDEF here means it was unrecognized or a mouse event.  */
> +	if (kbd.key != KBD_UNDEF)
> +		set_kbd_interlink_event(ev, kbd.key, kbd.modifier);
>  
>  	return el;
>  }

This should be in a separate patch. I was wondering what you had changed
in this or the previous patch that made it safe to remove the check for
ev->ev == EVENT_KBD, and then I realised that this check had been
unnecessary all along as kbd.key is initialised to KBD_UNDEF and is not
changed if decode_terminal_mouse_escape_sequence is called. I.e.,
mixing this change in confused me.

[...]
> diff --git a/src/terminal/kbd.h b/src/terminal/kbd.h
> index d8d5462..fb101cc 100644
> --- a/src/terminal/kbd.h
> +++ b/src/terminal/kbd.h
> @@ -4,46 +4,58 @@ #define EL__TERMINAL_KBD_H
>  struct itrm;
>  
>  struct term_event_keyboard {
> +	/* Values <= 0x100 are special; e.g. KBD_ENTER.

Shouldn't that be -0x100?

[...]
>  #define KBD_UNDEF	-1

Maybe a note here that these are values for struct term_event_keyboard,
not struct interlink_event_keyboard.

[...]
> +#define is_kbd_fkey(key) ((unsigned long) (KBD_F1 - (key)) <= (unsigned long) (KBD_F1 - KBD_F12))
[...]

Does it need to be this cryptic? How about just:

#define is_kbd_fkey(key) ((key) <= KBD_F1 && (key) >= KBD_F12)

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From mdm0304 at ecu.edu  Fri Aug  4 00:51:31 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Fri, 4 Aug 2006 06:51:31 +0000
Subject: [elinks-dev] [patch 1/5] Define separate structs for events passed
In-Reply-To: <87mzalz9qs.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87mzalz9qs.fsf@Astalo.kon.iki.fi>
Message-ID: <20060804065131.GB3649@FroodyComp.localdomain>

On Fri, Aug 04, 2006 at 02:21:15AM +0300, Kalle Olavi Niemitalo wrote:
> Define separate structs for events passed via the interlink socket.
> 
> This way, struct term_event can be changed without any interprocess
> compatibility problems.

It looks messy, but I don't know whether there is a better approach.
I'll need to think about it more. Of course, Jonas is the boss.

[...]
> diff --git a/src/terminal/event.c b/src/terminal/event.c
> index 291d3ef..58c53d8 100644
> --- a/src/terminal/event.c
> +++ b/src/terminal/event.c
> @@ -199,17 +199,18 @@ ignore_mouse_event(struct terminal *term
>  #endif
>  
>  static int
> -handle_interlink_event(struct terminal *term, struct term_event *ev)
> +handle_interlink_event(struct terminal *term, struct interlink_event *ilev)
[...]

What if we introduced a separate routine to convert term_event
to interlink_event, so as to minimise change to handle_interlink_event?

[...]
> -		term_send_event(term, ev);
> +		set_wh_term_event(&tev, ilev->ev,
> +				  ilev->info.size.width, ilev->info.size.height);
> +		term_send_event(term, &tev);

Why don't you use set_init_term_event?

[...]
> !-------------------------------------------------------------flip-
[...]

Oops, duplicated the other patches.

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From kon at iki.fi  Fri Aug  4 00:56:36 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 04 Aug 2006 09:56:36 +0300
Subject: [elinks-dev] Re: [patch 2/5] Renumber special keys to negative
	values, 
In-Reply-To: <20060804064120.GA3649@FroodyComp.localdomain>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87lkq5z9qi.fsf@Astalo.kon.iki.fi>
	<20060804064120.GA3649@FroodyComp.localdomain>
Message-ID: <87ac6lyonv.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060804/5e7de4fc/attachment.bin 

From kon at iki.fi  Sat Aug  5 01:15:25 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 10:15:25 +0300
Subject: [elinks-dev] Re: [patch 1/5] Define separate structs for events
	passed
In-Reply-To: <20060804065131.GB3649@FroodyComp.localdomain>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87mzalz9qs.fsf@Astalo.kon.iki.fi>
	<20060804065131.GB3649@FroodyComp.localdomain>
Message-ID: <87zmejy7oy.fsf@Astalo.kon.iki.fi>

Miciah Dashiel Butler Masters <mdm0304 at ecu.edu> writes:

> It looks messy, but I don't know whether there is a better approach.
> I'll need to think about it more. Of course, Jonas is the boss.

There are three reasons to have separate data formats for the
interlink protocol and for internal use in the master.

1. It allows the internal representation to be changed without
   worrying about compatibility.

2. It is good to have UCS-4 in struct term_event, but
   compatibility with ELinks 0.11 requires the interlink protocol
   to carry individual bytes, so using the same structures could
   be confusing.

   Instead of defining a whole separate struct interlink_event,
   this issue could also be solved by defining just a new event
   type for Unicode keyboard events, and a new structure in the
   term_event.info union.  However, that would require the
   structure to be kept small enough so that the size of the
   union does not change.

   When the interlink protocol is eventually changed (bug 793),
   this reason will no longer apply.  Instead...

3. The next version of the interlink protocol could even be made
   platform-independent, so that ELinks processes running on
   different platforms could communicate with each other.  This
   will be useful if there are 32-bit and 64-bit processes
   running on the same machine, or if a network file system
   allows AF_UNIX sockets to be contacted remotely.

> What if we introduced a separate routine to convert term_event
> to interlink_event, so as to minimise change to handle_interlink_event?

I don't see how that would help, as handle_interlink_event converts
From interlink_event to term_event, rather than vice versa.

> Why don't you use set_init_term_event?

Will do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/2175d8b0/attachment.bin 

From kon at iki.fi  Sat Aug  5 12:04:53 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:04:53 +0300
Subject: [elinks-dev] [patch 00/11] UTF-8: Use UCS-4 in struct
	term_event_keyboard.
In-Reply-To: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
Message-ID: <87mzajxdmi.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/e25004e9/attachment.bin 

From kon at iki.fi  Sat Aug  5 12:07:43 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:07:43 +0300
Subject: [elinks-dev] [patch 01/11] terminal: Decode UTF-8 only from bytes,
 not from codes of special keys.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87d5bfxdhs.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 01
Type: text/x-patch
Size: 897 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/b88b945b/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/b88b945b/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:08:57 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:08:57 +0300
Subject: [elinks-dev] [patch 02/11] terminal: Do not call toupper with
 potentially out-of-range values.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <878xm3xdfq.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 02
Type: text/x-patch
Size: 1092 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/d461008c/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/d461008c/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:09:42 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:09:42 +0300
Subject: [elinks-dev] [patch 03/11] terminal: decode_terminal_escape_sequence
 ignores previous value of *ev.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <874pwrxdeh.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 03
Type: text/x-patch
Size: 1362 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/8cd7b773/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/8cd7b773/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:10:40 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:10:40 +0300
Subject: [elinks-dev] [patch 04/11] terminal: Define separate structs for
 events passed via the interlink socket.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87zmejvysf.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 04
Type: text/x-patch
Size: 17320 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/cd4b6e6e/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/cd4b6e6e/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:11:33 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:11:33 +0300
Subject: [elinks-dev] [patch 05/11] terminal: Introduce macros for
 KBD_F1...KBD_F12 arithmetic.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87vep7vyqy.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 05
Type: text/x-patch
Size: 1863 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/c42973bd/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/c42973bd/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:12:54 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:12:54 +0300
Subject: [elinks-dev] [patch 06/11] config: Do not treat all negative key
 values like KBD_UNDEF.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87r6zvvyop.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 06
Type: text/x-patch
Size: 1035 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/b17af91f/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/b17af91f/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:14:09 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:14:09 +0300
Subject: [elinks-dev]
 [patch 07/11] Renumber special keys to negative values, 
 making room for Unicode.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87lkq3vymm.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 07
Type: text/x-patch
Size: 4464 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/92a70e22/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/92a70e22/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:15:04 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:15:04 +0300
Subject: [elinks-dev] [patch 08/11] terminal: term_send_ucs makes its own
	struct term_event.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87fygbvyl3.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 08
Type: text/x-patch
Size: 1816 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/af28af23/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/af28af23/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:16:17 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:16:17 +0300
Subject: [elinks-dev] [patch 09/11] terminal UTF-8: Translate all input via
 UCS-4, #ifdef CONFIG_UTF_8.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87ac6jvyj2.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 09
Type: text/x-patch
Size: 5515 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/8ea8e975/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/8ea8e975/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:17:16 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:17:16 +0300
Subject: [elinks-dev] [patch 10/11] UTF-8: New function
 unicode_fold_label_case and a related script.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <874pwrvyhf.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 10
Type: text/x-patch
Size: 6652 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/9a642dc5/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/9a642dc5/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:17:49 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:17:49 +0300
Subject: [elinks-dev] [patch 11/11] terminal UTF-8: term_event_keyboard.key
 is UCS-4, #ifdef CONFIG_UTF_8.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87zmejujw2.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: 11
Type: text/x-patch
Size: 8996 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/46d89c84/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/46d89c84/attachment-0001.bin 

From kon at iki.fi  Sat Aug  5 12:20:04 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:20:04 +0300
Subject: [elinks-dev] Re: [patch 00/11] UTF-8: Use UCS-4 in struct
	term_event_keyboard.
In-Reply-To: <87mzajxdmi.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <87vep7ujsb.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/827966da/attachment.bin 

From mdm0304 at ecu.edu  Sat Aug  5 12:26:50 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Sat, 5 Aug 2006 18:26:50 +0000
Subject: [elinks-dev] Re: [patch 1/5] Define separate structs for events
In-Reply-To: <87zmejy7oy.fsf@Astalo.kon.iki.fi>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87zmejy7oy.fsf@Astalo.kon.iki.fi>
Message-ID: <20060805182649.GA29472@FroodyComp.localdomain>

On Sat, Aug 05, 2006 at 10:15:25AM +0300, Kalle Olavi Niemitalo wrote:
> Miciah Dashiel Butler Masters <mdm0304 at ecu.edu> writes:
[...]
> > What if we introduced a separate routine to convert term_event
> > to interlink_event, so as to minimise change to handle_interlink_event?
> 
> I don't see how that would help, as handle_interlink_event converts
> From interlink_event to term_event, rather than vice versa.
[...]

How about a separate routine to convert from interlink_event
to term_event?

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From kon at iki.fi  Sat Aug  5 12:42:23 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 21:42:23 +0300
Subject: [elinks-dev] Re: [patch 1/5] Define separate structs for events
In-Reply-To: <20060805182649.GA29472@FroodyComp.localdomain>
References: <878xm51m1j.fsf@Astalo.kon.iki.fi>
	<87zmejy7oy.fsf@Astalo.kon.iki.fi>
	<20060805182649.GA29472@FroodyComp.localdomain>
Message-ID: <87mzajuir4.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/7087af63/attachment.bin 

From mdm0304 at ecu.edu  Sat Aug  5 13:34:04 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Sat, 5 Aug 2006 19:34:04 +0000
Subject: [elinks-dev] [patch 04/11] terminal: Define separate structs for
In-Reply-To: <87zmejvysf.fsf_-_@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87zmejvysf.fsf_-_@Astalo.kon.iki.fi>
Message-ID: <20060805193404.GB29472@FroodyComp.localdomain>

On Sat, Aug 05, 2006 at 09:10:40PM +0300, Kalle Olavi Niemitalo wrote:
> terminal: Define separate structs for events passed via the interlink socket.
> 
> This way, struct term_event can be changed without any interprocess
> compatibility problems.
[...]
> +struct interlink_event {
> +	enum term_event_type ev;
> +
> +	union {
> +		/* EVENT_MOUSE */
> +		struct interlink_event_mouse mouse;
> +
> +		/* EVENT_KBD */
> +		struct interlink_event_keyboard keyboard;
> +
> +		/* EVENT_INIT, EVENT_RESIZE, EVENT_REDRAW */
> +#define interlink_event_size term_event_size
> +		struct interlink_event_size size;
> +	} info;
> +};

Maybe you should do the same for enum term_event_type as you do for
struct term_event_size.

[...]
> @@ -671,7 +671,7 @@ decode_terminal_escape_sequence(struct i
>  		    && itrm->in.queue.data[3] >= 'A'
>  		    && itrm->in.queue.data[3] <= 'L') {
>  			kbd.key = KBD_F1 + itrm->in.queue.data[3] - 'A';
> -			copy_struct(&ev->info.keyboard, &kbd);
> +			set_kbd_interlink_event(ev, kbd.key, kbd.modifier);
[...]
> -	struct term_event_keyboard kbd = { KBD_UNDEF, KBD_MOD_NONE };
> +	struct interlink_event_keyboard kbd = { KBD_UNDEF, KBD_MOD_NONE };
[...]
> -			copy_struct(&ev.info.keyboard, &os2xtd[itrm->in.queue.data[1]]);
> +			set_kbd_interlink_event(&ev,
> +						os2xtd[itrm->in.queue.data[1]].key,
> +						os2xtd[itrm->in.queue.data[1]].modifier);
[...]

Maybe this isn't the best thread in which to bring this up, but reading
code like this leads me to wonder why we have set_kbd_term_event,
kbd_set, and so on. Right here, you show that we aren't doing it for
opacity, and surely they don't make such a huge dent in LOC. All they do
is hide some memsets and assignments behind mazes of macros.

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From kon at iki.fi  Sat Aug  5 14:46:40 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 05 Aug 2006 23:46:40 +0300
Subject: [elinks-dev] Re: [patch 04/11] terminal: Define separate structs for
In-Reply-To: <20060805193404.GB29472@FroodyComp.localdomain>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87zmejvysf.fsf_-_@Astalo.kon.iki.fi>
	<20060805193404.GB29472@FroodyComp.localdomain>
Message-ID: <87irl6vrkf.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060805/3455d9f1/attachment.bin 

From kon at iki.fi  Sun Aug  6 04:25:44 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 06 Aug 2006 13:25:44 +0300
Subject: [elinks-dev] UTF-8: ELinks assumes towlower uses UCS-4
Message-ID: <87d5beupnb.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060806/453000f2/attachment.bin 

From kon at iki.fi  Sun Aug  6 05:15:15 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 06 Aug 2006 14:15:15 +0300
Subject: [elinks-dev] Re: [patch] terminal: Read modifiers from the first
 UTF-8 byte, not the last.
In-Reply-To: <878xmb2own.fsf@Astalo.kon.iki.fi>
References: <878xmb2own.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
Message-ID: <874pwquncs.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 2123 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060806/d81bfb32/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060806/d81bfb32/attachment-0001.bin 

From kon at iki.fi  Sun Aug  6 05:40:44 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 06 Aug 2006 14:40:44 +0300
Subject: [elinks-dev] [patch] do_auth_dialog: Fix off-by-one error leading to
 reads of uninitialized memory.
Message-ID: <87zmeit7lv.fsf@Astalo.kon.iki.fi>

do_auth_dialog: Fix off-by-one error leading to reads of uninitialized memory.

This bug manifested as a junk character at the end of the text in the
authentication dialog.

---
commit 7f872d610a81d978717dfdb1c4f649bf3e8253d7
tree ba370a886387e1da89f1a9c3a16bffc3ab997340
parent 5b260ad69d031d0edf12e17a69b68de8db0bebc8
author Kalle Olavi Niemitalo <kon at iki.fi> Sat, 24 Jun 2006 16:41:16 +0300
committer Kalle Olavi Niemitalo <Kalle at Astalo.kon.iki.fi> Sun, 06 Aug 2006 14:32:17 +0300

 src/protocol/auth/dialogs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/protocol/auth/dialogs.c b/src/protocol/auth/dialogs.c
index 6c88578..47e10e2 100644
--- a/src/protocol/auth/dialogs.c
+++ b/src/protocol/auth/dialogs.c
@@ -90,7 +90,8 @@ do_auth_dialog(struct session *ses, void
 	if (sticker_len < 0 || sticker_len > MAX_STR_LEN) return;
 
 #define AUTH_WIDGETS_COUNT 5
-	dlg = calloc_dialog(AUTH_WIDGETS_COUNT, sticker_len);
+	/* + 1 to leave room for the '\0'. */
+	dlg = calloc_dialog(AUTH_WIDGETS_COUNT, sticker_len + 1);
 	if (!dlg) return;
 
 	a->blocked = 1;
@@ -99,7 +100,7 @@ #define AUTH_WIDGETS_COUNT 5
 	dlg->layouter = generic_dialog_layouter;
 
 	text = get_dialog_offset(dlg, AUTH_WIDGETS_COUNT);
-	memcpy(text, sticker, sticker_len);
+	memcpy(text, sticker, sticker_len); /* calloc_dialog has stored '\0' */
 
 	dlg->udata = (void *) ses;
 	dlg->udata2 = a;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060806/ab41d289/attachment.bin 

From kon at iki.fi  Sun Aug  6 05:42:00 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 06 Aug 2006 14:42:00 +0300
Subject: [elinks-dev] [patch] do_auth_dialog: Don't claim that the
 authentication is for HTTP.
Message-ID: <87vep6t7jr.fsf@Astalo.kon.iki.fi>

do_auth_dialog: Don't claim that the authentication is for HTTP.

---
commit bac061244dfedd0dd97025d98d7850330b89bbf3
tree 78e37fde3a9cc177602d6fe974e3e615cfb71119
parent 7f872d610a81d978717dfdb1c4f649bf3e8253d7
author Kalle Olavi Niemitalo <kon at iki.fi> Sun, 02 Jul 2006 23:19:48 +0300
committer Kalle Olavi Niemitalo <Kalle at Astalo.kon.iki.fi> Sun, 06 Aug 2006 14:33:18 +0300

 src/protocol/auth/dialogs.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/protocol/auth/dialogs.c b/src/protocol/auth/dialogs.c
index 47e10e2..0722df1 100644
--- a/src/protocol/auth/dialogs.c
+++ b/src/protocol/auth/dialogs.c
@@ -96,7 +96,10 @@ #define AUTH_WIDGETS_COUNT 5
 
 	a->blocked = 1;
 
-	dlg->title = _("HTTP Authentication", term);
+	/* This function is used for at least HTTP and FTP, so don't
+	 * name the protocol here.  Consider also what an FTP server
+	 * behind an HTTP proxy should be called.  */
+	dlg->title = _("Authentication required", term);
 	dlg->layouter = generic_dialog_layouter;
 
 	text = get_dialog_offset(dlg, AUTH_WIDGETS_COUNT);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060806/9e4afa17/attachment.bin 

From kon at iki.fi  Sun Aug  6 15:51:33 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Mon, 07 Aug 2006 00:51:33 +0300
Subject: [elinks-dev] Re: [patch 00/11] UTF-8: Use UCS-4 in struct
	term_event_keyboard.
In-Reply-To: <87vep7ujsb.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi> <87vep7ujsb.fsf@Astalo.kon.iki.fi>
Message-ID: <87irl5ttwa.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060807/4fd7d27e/attachment.bin 

From fonseca at diku.dk  Tue Aug  8 13:43:48 2006
From: fonseca at diku.dk (Jonas Fonseca)
Date: Tue, 8 Aug 2006 21:43:48 +0200
Subject: [elinks-dev] [patch 10/11] UTF-8: New function
	unicode_fold_label_case and a related script.
In-Reply-To: <874pwrvyhf.fsf_-_@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
	<874pwrvyhf.fsf_-_@Astalo.kon.iki.fi>
Message-ID: <20060808194347.GA9621@diku.dk>

Kalle Olavi Niemitalo <kon at iki.fi> wrote Sat, Aug 05, 2006:
> +unicode_val_T
> +unicode_fold_label_case(unicode_val_T c)
> +{
> +#if __STDC_ISO_10646__ && HAVE_WCTYPE_H
> +	return towlower(c);
> +#else  /* !(__STDC_ISO_10646__ && HAVE_WCTYPE_H) */
> +	/* For now, this supports only ASCII.  It would be possible to
> +	 * use code generated from CaseFolding.txt of Unicode if the
> +	 * acknowledgements required by http://www.unicode.org/copyright.html
> +	 * were added to associated documentation of ELinks.  */
> +	if (c >= 0x41 && c <= 0x5A)
> +		return c + 0x20;
> +	else
> +		return c;
> +#endif /* !(__STDC_ISO_10646__ && HAVE_WCTYPE_H) */
> +}

We already have derivative work of the Unicode SGML entity table.
So adding this to the documentation should be done anyway.

Scrool and I talked about using UCData for handling Unicode character
properties. In the long run, we probably want to have functions for
checking and modifying character properties other than case. Don't know
if including ucdata is overdoing it though.

As I understand it it works by generating binary files with the
character properties. A C program for doing this exists in the sources.
These binary files can then be loaded at runtime as needed. However, if
ELinks was to use ucdata the binary data should probably be included in
the final binary.

 - http://crl.nmsu.edu/~mleisher/ucdata.html

-- 
Jonas Fonseca


From fonseca at diku.dk  Tue Aug  8 13:47:47 2006
From: fonseca at diku.dk (Jonas Fonseca)
Date: Tue, 8 Aug 2006 21:47:47 +0200
Subject: [elinks-dev] Re: [patch 00/11] UTF-8: Use UCS-4 in struct
	term_event_keyboard.
In-Reply-To: <87irl5ttwa.fsf@Astalo.kon.iki.fi>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
	<87vep7ujsb.fsf@Astalo.kon.iki.fi>
	<87irl5ttwa.fsf@Astalo.kon.iki.fi>
Message-ID: <20060808194747.GB9621@diku.dk>

Kalle Olavi Niemitalo <kon at iki.fi> wrote Mon, Aug 07, 2006:
> Kalle Olavi Niemitalo <kon at iki.fi> writes:
> 
> > These patches are also temporarily available via GIT at
> > <http://www.iki.fi/kon/2006/elinks.git#term_event_utf8_4>.
> 
> Removed.

Curious. Why removed?

-- 
Jonas Fonseca


From mdm0304 at ecu.edu  Tue Aug  8 14:02:41 2006
From: mdm0304 at ecu.edu (Miciah Dashiel Butler Masters)
Date: Tue, 8 Aug 2006 20:02:41 +0000
Subject: [elinks-dev] Re: [patch 00/11] UTF-8: Use UCS-4 in struct
In-Reply-To: <20060808194747.GB9621@diku.dk>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi> <20060808194747.GB9621@diku.dk>
Message-ID: <20060808200241.GA4422@FroodyComp.localdomain>

On Tue, Aug 08, 2006 at 09:47:47PM +0200, Jonas Fonseca wrote:
> Kalle Olavi Niemitalo <kon at iki.fi> wrote Mon, Aug 07, 2006:
> > Kalle Olavi Niemitalo <kon at iki.fi> writes:
> > 
> > > These patches are also temporarily available via GIT at
> > > <http://www.iki.fi/kon/2006/elinks.git#term_event_utf8_4>.
> > 
> > Removed.
> 
> Curious. Why removed?

To save space, maybe? I committed them Sunday.

-- 
Miciah Masters <miciah at myrealbox.com> / <mdm0304 at ecu.edu>


From kon at iki.fi  Thu Aug 10 15:46:00 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 11 Aug 2006 00:46:00 +0300
Subject: [elinks-dev] Unicode character database licensing & inclusion (was:
 [patch 10/11]
 UTF-8: New function unicode_fold_label_case and a related script.)
In-Reply-To: <20060808194347.GA9621@diku.dk>
References: <87odv1z9r0.fsf@Astalo.kon.iki.fi>
	<87mzajxdmi.fsf@Astalo.kon.iki.fi>
	<874pwrvyhf.fsf_-_@Astalo.kon.iki.fi>
	<20060808194347.GA9621@diku.dk>
Message-ID: <87y7twnu1z.fsf_-_@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060811/8d80a5a7/attachment.bin 

From kon at iki.fi  Sat Aug 12 00:52:56 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sat, 12 Aug 2006 09:52:56 +0300
Subject: [elinks-dev] Bug 794 - tab-close-all-but-current crashes
Message-ID: <87irkyh2d3.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060812/82bcf770/attachment.bin 

From kon at iki.fi  Sat Aug 12 15:12:15 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 13 Aug 2006 00:12:15 +0300
Subject: [elinks-dev] [patch] do_file_menu: Correct the order of arguments in
 SET_MENU_ITEM invocations.
Message-ID: <87veoxek0g.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: text/x-patch
Size: 1588 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060813/83ef6b92/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060813/83ef6b92/attachment-0001.bin 

From tk at giga.or.at  Mon Aug 14 07:44:33 2006
From: tk at giga.or.at (Thomas Klausner)
Date: Mon, 14 Aug 2006 15:44:33 +0200
Subject: [elinks-dev] elinks-0.11.1: patches for compilation against
	lua-5.1.1
Message-ID: <20060814134433.GG27821@danbala.tuwien.ac.at>

Hi!

lua 5.1.1 has some API changes compared to 5.0 that break elinks-0.11.1.
One of them is that liblualib was been folded into liblua.

configure breaks with:
conftest.c: In function 'main':
conftest.c:130: warning: implicit declaration of function 'luaL_newstate'
conftest.c:130: warning: initialization makes pointer from integer without a cast
conftest.c:131: warning: implicit declaration of function 'lua_baselibopen'
conftest.c:132: warning: implicit declaration of function 'lua_mathlibopen'
conftest.c:133: warning: implicit declaration of function 'lua_strlibopen'
conftest.c:134: warning: implicit declaration of function 'lua_tablibopen'
/var/tmp//ccYrS9zX.o: In function `main':
conftest.c:(.text+0x1b): undefined reference to `lua_baselibopen'
conftest.c:(.text+0x23): undefined reference to `lua_mathlibopen'
conftest.c:(.text+0x2b): undefined reference to `lua_strlibopen'
conftest.c:(.text+0x33): undefined reference to `lua_tablibopen'

patch-aa solves this one and the removed library.

Later, linking fails with:
lib.o: In function `handle_ret_eval':
core.c:(.text+0x5907b): undefined reference to `lua_dostring'
lib.o: In function `do_hooks_file':
core.c:(.text+0x59144): undefined reference to `lua_dofile'
lib.o: In function `script_hook_quit':
hooks.c:(.text+0x5a997): undefined reference to `lua_dostring'

patch-ab and patch-ac solve these.

Please test and integrate them in some way!

Thanks,
 Thomas

P.S.: Please cc me any replies, I'm not on this list.
-------------- next part --------------
$NetBSD$

--- configure.orig	2006-01-29 13:10:47.000000000 +0000
+++ configure
@@ -17103,7 +17103,7 @@ if test -z "$disable_lua"; then
 	for luadir in "$withval" "" /usr /usr/local; do
 		for suffix in "" 50 51; do
 			if test "$cf_result" = no; then
-				LUA_LIBS="-llua$suffix -llualib$suffix -lm"
+				LUA_LIBS="-llua$suffix -lm"
 
 				if test ! -z "$luadir"; then
 					LUA_LIBS="-L$luadir/lib $LUA_LIBS"
@@ -17127,10 +17127,10 @@ int
 main ()
 {
 	lua_State *L = lua_open();
-						lua_baselibopen(L);
-						lua_mathlibopen(L);
-						lua_strlibopen(L);
-						lua_tablibopen(L);
+						luaopen_base(L);
+						luaopen_math(L);
+						luaopen_string(L);
+						luaopen_table(L);
 						lua_pushboolean(L, 1);
 						lua_close(L);
   ;
-------------- next part --------------
$NetBSD$

--- src/scripting/lua/core.c.orig	2006-01-29 13:10:39.000000000 +0000
+++ src/scripting/lua/core.c
@@ -633,7 +633,7 @@ do_hooks_file(LS, unsigned char *prefix,
 	if (file_can_read(file)) {
 		int oldtop = lua_gettop(S);
 
-		if (lua_dofile(S, file) != 0)
+		if (luaL_dofile(S, file) != 0)
 			sleep(3); /* Let some time to see error messages. */
 		lua_settop(S, oldtop);
 	}
@@ -755,7 +755,7 @@ handle_ret_eval(struct session *ses)
 		int oldtop = lua_gettop(L);
 
 		if (prepare_lua(ses) == 0) {
-			lua_dostring(L, expr);
+			luaL_dostring(L, expr);
 			lua_settop(L, oldtop);
 			finish_lua();
 		}
-------------- next part --------------
$NetBSD$

--- src/scripting/lua/hooks.c.orig	2006-01-29 13:10:39.000000000 +0000
+++ src/scripting/lua/hooks.c
@@ -200,7 +200,7 @@ static enum evhook_status
 script_hook_quit(va_list ap, void *data)
 {
 	if (!prepare_lua(NULL)) {
-		lua_dostring(lua_state, "if quit_hook then quit_hook() end");
+		luaL_dostring(lua_state, "if quit_hook then quit_hook() end");
 		finish_lua();
 	}
 

From kon at iki.fi  Sun Aug 20 16:30:59 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Mon, 21 Aug 2006 01:30:59 +0300
Subject: [elinks-dev] UTF-8 decoding changes for handle_interlink_event
Message-ID: <87wt93kpjw.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060821/93f38017/attachment.bin 

From kon at iki.fi  Fri Aug 25 14:42:41 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Fri, 25 Aug 2006 23:42:41 +0300
Subject: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event
In-Reply-To: <87wt93kpjw.fsf@Astalo.kon.iki.fi>
References: <87wt93kpjw.fsf@Astalo.kon.iki.fi>
Message-ID: <87u040pmwu.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060825/a58afa5d/attachment.bin 

From fonseca at diku.dk  Sat Aug 26 07:15:53 2006
From: fonseca at diku.dk (Jonas Fonseca)
Date: Sat, 26 Aug 2006 15:15:53 +0200
Subject: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event
In-Reply-To: <87u040pmwu.fsf@Astalo.kon.iki.fi>
References: <87wt93kpjw.fsf@Astalo.kon.iki.fi>
	<87u040pmwu.fsf@Astalo.kon.iki.fi>
Message-ID: <20060826131553.GA11103@diku.dk>

Kalle Olavi Niemitalo <kon at iki.fi> wrote Fri, Aug 25, 2006:
> Kalle Olavi Niemitalo <kon at iki.fi> writes:
> 
> > I'd like to merge <http://www.iki.fi/kon/2006/elinks.git#utf8min>
> > to the main repository.
> 
> I have now committed patches that have a similar effect.

Two things:

 - You indented the goto label in the first commit (e333fb37) and
   normally labels should not be indented.

 - I don't seem to remember the introduction of is_utf16_surrogate()
   used in the second commit (be7526d0). Did you forgot to add
   intl/charset.h to the file commit list?

-- 
Jonas Fonseca


From witekfl at poczta.onet.pl  Sat Aug 26 12:56:55 2006
From: witekfl at poczta.onet.pl (Witold Filipczyk)
Date: Sat, 26 Aug 2006 20:56:55 +0200
Subject: [elinks-dev] gdb and files with the same names
Message-ID: <20060826185655.GA3985@pldmachine>

Hi,
Having files with the same names in the project is bad, because gdb
cannot deal with them in the right way. gdb remembers only basenames,
because object files are built from directory where sources are stored.
When gdb meet eg. renderer.c, it doesn't know which file it is.
I have a problem with debugging ELinks using setedit. It by mistake
opens src/dom/select.c instead of src/main/select.c.
Renaming files will solve the problem.

Do you mind if I rename duplicates?
Do you have any suggestion how to name those files?

I cannot agree, that gdb is broken, IMHO build process of ELinks
is broken and there shouldn't be duplicate filenames.
-- 
Witek



From kon at iki.fi  Sat Aug 26 15:59:41 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 27 Aug 2006 00:59:41 +0300
Subject: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event
In-Reply-To: <20060826131553.GA11103@diku.dk>
References: <87wt93kpjw.fsf@Astalo.kon.iki.fi>
	<87u040pmwu.fsf@Astalo.kon.iki.fi> <20060826131553.GA11103@diku.dk>
Message-ID: <87ejv3p38y.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060827/81ae9020/attachment.bin 

From kon at iki.fi  Sun Aug 27 03:57:40 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Sun, 27 Aug 2006 12:57:40 +0300
Subject: [elinks-dev] Turkish dotted and dotless I
Message-ID: <877j0upkkr.fsf@Astalo.kon.iki.fi>

In Turkish and some other languages, there are upper-case and
lower-case variants of both dotted i/? and dotless ?/I.  If I
understand correctly, Turkish users expect case-insensitive
comparisons to treat "i" as equivalent to "?", and "?" as
equivalent to "I".  ELinks does case-insensitive comparisons
in at least these situations:

- searching for text in a document
- comparing a keystroke to an HTML accesskey attribute
- comparing a keystroke to the accelerator key of a BFU widget or
  menu item

Currently, these comparisons try to use towupper() or towlower(),
which in turn use the locale selected for LC_CTYPE.  Because
init_osdep() calls setlocale(LC_ALL, ""), the locale is selected
based on environment variables on POSIX, or based on the user
default ANSI code page on Windows.  (Because all the comparisons
occur in the master ELinks process, the locale environment
variables of slave ELinks processes do not affect them.)

Is this the appropriate behaviour, or should ELinks enable the
Turkish case mappings whenever the user selects Turkish from the
language menu, regardless of environment variables?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060827/34146a71/attachment.bin 

From kon at iki.fi  Sun Aug 27 15:20:25 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Mon, 28 Aug 2006 00:20:25 +0300
Subject: [elinks-dev] Re: gdb and files with the same names
In-Reply-To: <20060826185655.GA3985@pldmachine>
References: <20060826185655.GA3985@pldmachine>
Message-ID: <873bbhq3ja.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060828/a35a7ca8/attachment.bin 

From kon at iki.fi  Sun Aug 27 15:27:04 2006
From: kon at iki.fi (Kalle Olavi Niemitalo)
Date: Mon, 28 Aug 2006 00:27:04 +0300
Subject: [elinks-dev] UTF-8: fix scrolling of input fields
Message-ID: <87y7t9oonr.fsf@Astalo.kon.iki.fi>

A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://linuxfromscratch.org/pipermail/elinks-dev/attachments/20060828/624fce58/attachment.bin 

From fonseca at diku.dk  Mon Aug 28 10:29:51 2006
From: fonseca at diku.dk (Jonas Fonseca)
Date: Mon, 28 Aug 2006 18:29:51 +0200
Subject: [elinks-dev] Re: UTF-8 decoding changes for handle_interlink_event
In-Reply-To: <87ejv3p38y.fsf@Astalo.kon.iki.fi>
References: <87wt93kpjw.fsf@Astalo.kon.iki.fi>
	<87u040pmwu.fsf@Astalo.kon.iki.fi> <20060826131553.GA11103@diku.dk>
	<87ejv3p38y.fsf@Astalo.kon.iki.fi>
Message-ID: <20060828162951.GA8005@diku.dk>

Kalle Olavi Niemitalo <kon at iki.fi> wrote Sun, Aug 27, 2006:
> Jonas Fonseca <fonseca at diku.dk> writes:
> 
> >  - You indented the goto label in the first commit (e333fb37) and
> >    normally labels should not be indented.
> 
> Oops.  I see that's in doc/hacking.txt too.  I guess I'll have to
> configure Emacs to use a custom indentation style for ELinks code.

It's not a big deal. It would be better not to use goto at all. ;)

> >  - I don't seem to remember the introduction of is_utf16_surrogate()
> >    used in the second commit (be7526d0). Did you forgot to add
> >    intl/charset.h to the file commit list?
> 
> I added is_utf16_surrogate in commit 38fe5b72 aka be7526d0~2,
> "Define and use macros for handling UTF-16 surrogates."
> I typically commit a whole tree, rather than individual files.

Ok, sorry for the noise then.

-- 
Jonas Fonseca