[blfs-dev] ... pygobject patch

Fernando de Oliveira famobr at yahoo.com.br
Tue Mar 4 15:31:59 PST 2014


Em 04-03-2014 17:23, Armin K. escreveu:

>>
>> Didn't you get a problem, when testing the patch?
>>
>> Only if I first apply pygobject-2.28.6-introspection-1.patch that is in
>> the book, then, apply pygobject-2.28.6-git_fixes-1.patch, it works.
>>
>> With just
>>
>> patch -Np1 -i ../pygobject-2.28.6-git_fixes-1.patch, "make" breaks with
>> messages:
>>
>> {{{
>> pygi-repository.c: In function '_wrap_g_irepository_require':
>> pygi-repository.c:92:15: warning: variable 'typelib' set but not used
>> [-Wunused-but-set-variable]
>>      GTypelib *typelib;
>>                ^
>>   CC     _gi_la-pygi-info.lo
>> pygi-info.c: In function '_pygi_info_new':
>> pygi-info.c:165:14: error: 'GI_INFO_TYPE_ERROR_DOMAIN' undeclared (first
>> use in this function)
>>          case GI_INFO_TYPE_ERROR_DOMAIN:
>>               ^
>> pygi-info.c:165:14: note: each undeclared identifier is reported only
>> once for each function it appears in
>> pygi-info.c:135:5: warning: enumeration value 'GI_INFO_TYPE_INVALID_0'
>> not handled in switch [-Wswitch]
>>      switch (info_type)
>>      ^
>> pygi-info.c: In function '_pygi_g_type_info_size':
>> pygi-info.c:484:22: error: 'GI_INFO_TYPE_ERROR_DOMAIN' undeclared (first
>> use in this function)
>>                  case GI_INFO_TYPE_ERROR_DOMAIN:
>>                       ^
>> pygi-info.c:448:13: warning: enumeration value 'GI_INFO_TYPE_INVALID_0'
>> not handled in switch [-Wswitch]
>>              switch (info_type) {
>>              ^
>> pygi-info.c: In function 'pygi_g_struct_info_is_simple':
>> pygi-info.c:863:26: error: 'GI_INFO_TYPE_ERROR_DOMAIN' undeclared (first
>> use in this function)
>>                      case GI_INFO_TYPE_ERROR_DOMAIN:
>>                           ^
>> pygi-info.c:835:17: warning: enumeration value 'GI_INFO_TYPE_INVALID_0'
>> not handled in switch [-Wswitch]
>>                  switch (info_type) {
>>                  ^
>> Makefile:528: recipe for target '_gi_la-pygi-info.lo' failed
>> make[3]: *** [_gi_la-pygi-info.lo] Error 1
>> make[3]: Leaving directory
>> '/home/fernando/tmp/paco-build-2014.03.04-16h40m46s/pygobject-2.28.6/gi'
>> Makefile:690: recipe for target 'all-recursive' failed
>> make[2]: *** [all-recursive] Error 1
>> make[2]: Leaving directory
>> '/home/fernando/tmp/paco-build-2014.03.04-16h40m46s/pygobject-2.28.6/gi'
>> Makefile:615: recipe for target 'all-recursive' failed
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory
>> '/home/fernando/tmp/paco-build-2014.03.04-16h40m46s/pygobject-2.28.6'
>> Makefile:376: recipe for target 'all' failed
>> make: *** [all] Error 2
>> }}}
>>
>> which seems exactly the fix needed from
>> pygobject-2.28.6-introspection-1.patch.
>>
>> Unfortunately, I do not feel we can end the discussion before 7.5 is
>> released.
>>
>> My doubts, first, is this new patch required or optional, because the
>> other one is optional? second, should it be a second patch, not a
>> replacement patch?
>>
> 
> Hm, indeed you need the patch that's in the book. My suggestion is
> squashing both of them into one single patch and adding it into the
> book. Required seems to be a good choice since it will also fix a
> crasher in pygtk apps that I've seen some time ago.
> 

Done. Committed revision 2850 (patch). Committed revision 12820 (text).

-- 
[]s,
Fernando



More information about the blfs-dev mailing list