FAM patch and patches in general

Tushar Teredesai tushar at linuxfromscratch.org
Mon Jun 2 19:56:15 PDT 2003


Dagmar d'Surreal wrote:

>OKay, this came up at one time in the past, and apparently got
>ignored... I'm going to again recommend that all patches have comments
>placed at their heads explaining where they came from (to give credit,
>especially where patches have been appropriated from other sources) and
>what they do (so that it can be more easily determined when they become
>obsolete).
>
Good suggestion, will try to include it in the patches I commit.

>The reason being that it's been brought to my attention that the book
>doesn't call for one to execute autoconf after applying the dnotify
>patch to fam sources.  Possibly if someone had looked at the patch
>carefully while adding comments explaining they got it from SGI (which
>in my opinion doubles as a warning to the user.  Heh) they would have
>realized that the patch only modifies configure.in and makes things in
>other files dependent on an environment variable which never gets set
>unless you regenerate the configure script.
>
I am the guilty party, I meant to discuss running autotools on the fam 
source on blfs-dev and forgot.

>(Before anyone can go there, making a new diff after running autoconf
>results in a pretty huge and boring diff file, which is probably why SGI
>didn't do it that way themselves)
>
>  
>
Good thing is the patch will be included in the 2.7 release.

-- 
Tushar Teredesai
   http://www.linuxfromscratch.org/~tushar/
   http://www.geocities.com/tushar/


-- 
Unsubscribe: send email to listar at linuxfromscratch.org
and put 'unsubscribe blfs-dev' in the subject header of the message



More information about the blfs-dev mailing list