r7771

Thomas Trepl thomas at equinox.homelinux.org
Sun Feb 22 08:12:07 PST 2009


Am Sunday 22 February 2009 15:44:01 schrieb Randy McMurchy:
> thomas at linuxfromscratch.org wrote these words on 02/22/09 08:12 CST:
> > Author: thomas
> > Date: 2009-02-22 07:12:45 -0700 (Sun, 22 Feb 2009)
> > New Revision: 7771
> >
> > Modified:
> >    trunk/BOOK/general.ent
> >    trunk/BOOK/introduction/welcome/changelog.xml
> >    trunk/BOOK/pst/ps/a2ps.xml
> > Log:
> > Fix configure issues in a2ps
> >
> > -<!ENTITY day          "19">                   <!-- Always 2 digits -->
> > +<!ENTITY day          "22">                   <!-- Always 2 digits -->
>
> Wouldn't you also need to change the "th" to "nd" a few lines down?
>
> > +      <para>February 22th, 2009</para>
>
> That should be February 22nd, 2009
Fixed

>
> > +    <bridgehead renderas="sect4">Required</bridgehead>
> > +    <para role="required"><xref linkend="gperf"/></para>
>
> We usually place a blank line between sections such as this.
Yes we should.  Fixed.

>
> >      <bridgehead renderas="sect4">Recommended</bridgehead>
> >      <para role="recommended"><xref linkend="psutils"/>, and
> >
> >
> > +    <para>First run <command>autoconf</command> to recreate the
> > +    <filename>configure</filename> script. This is required cause
>
> s/cause/because/
Fixed

>
> > +    there is an issue in the mktime test which would cause the
> > +    <filename>configure</filename> to hang for 60 seconds and than
> > +    report that there is no working mktime function.</para>
> > +
> > +<screen><userinput>autoconf</userinput></screen>
> > +
> > +    <para>Fix a bug in the handling of the version output of
> > +    <command>gperf</command>:</para>
> > +
> > +<screen><userinput>sed -i "s;GPERF --version |;& head -n 1 |;"
> > configure</userinput></screen> +
>
> Would you place all the commands together in the area below and then place
> the comments in the "Commands Explanations" section. It makes it so much
> easier for folks to cut and paste. Additionally, that is how the majority
> of the book is written.
I see.  Fixed
>
> >      <para>Install <application>a2ps</application> by running the
> > following commands:</para>
> >
> > -<screen><userinput>sed -i 's/+0 -1/-k 1,2/' afm/make_fonts_map.sh
> > && -sed -i "s|/usr/local/share|/usr/share|" configure &&
> > +<screen><userinput>sed -i "s;/usr/local/share;/usr/share;" configure
> > &&
>
> Why change the delimiter? Some editor before you felt "|" was better than
> ";". Not sure changing it is good here. :-)
This was because I needed to include the | in the regex of the new sed. 
Therefore there was the need for selecting a different delimiter - my choice 
was ;  Ok, I'll look to the section again - but i my chances are not quite 
good because i need to insert another | in that GPERF --version command...
>
> +++++ another mail +++++
>
>I noticed a couple more things: 
>
>> +    <para>First run <command>autoconf</command> to recreate the
>> +    <filename>configure</filename> script. This is required cause
>> +    there is an issue in the mktime test which would cause the
>> +    <filename>configure</filename> to hang for 60 seconds and than
>
>Either say "the configure command", or remove the "the". Right now
>it is incorrect. Additionally, because configure is an actual command,
>the proper tags would be <command>configure</command>.
Fixed

>> +<screen><userinput>sed -i "s;GPERF --version |;& head -n 1 |;" 
>configure</userinput></screen>
>
>Typically we've always used the "/" as the delimiter if there are no other
>"/" in the expressions. Using the ";" in this case is confusing to me as
>there are 4 of them used above. One is used in &. I would rather use
>the more conventional "/".
Well, the fourth ; is indeed a result of the & . Well, the problem in the 
sed is, that i cannot use the | as delimiter because it is an element of the 
replacement string. I now use the /
Optically it is not that fine, but as it is now, i think we can live with, do 
we?

--
Thomas



More information about the blfs-book mailing list