r7771

Randy McMurchy randy at linuxfromscratch.org
Sun Feb 22 06:44:01 PST 2009


thomas at linuxfromscratch.org wrote these words on 02/22/09 08:12 CST:
> Author: thomas
> Date: 2009-02-22 07:12:45 -0700 (Sun, 22 Feb 2009)
> New Revision: 7771
> 
> Modified:
>    trunk/BOOK/general.ent
>    trunk/BOOK/introduction/welcome/changelog.xml
>    trunk/BOOK/pst/ps/a2ps.xml
> Log:
> Fix configure issues in a2ps
>
> -<!ENTITY day          "19">                   <!-- Always 2 digits -->
> +<!ENTITY day          "22">                   <!-- Always 2 digits -->

Wouldn't you also need to change the "th" to "nd" a few lines down?



> +      <para>February 22th, 2009</para>

That should be February 22nd, 2009


> +    <bridgehead renderas="sect4">Required</bridgehead>
> +    <para role="required"><xref linkend="gperf"/></para>

We usually place a blank line between sections such as this.

>      <bridgehead renderas="sect4">Recommended</bridgehead>
>      <para role="recommended"><xref linkend="psutils"/>, and


> +    <para>First run <command>autoconf</command> to recreate the
> +    <filename>configure</filename> script. This is required cause

s/cause/because/


> +    there is an issue in the mktime test which would cause the
> +    <filename>configure</filename> to hang for 60 seconds and than
> +    report that there is no working mktime function.</para>
> +
> +<screen><userinput>autoconf</userinput></screen>
> +
> +    <para>Fix a bug in the handling of the version output of
> +    <command>gperf</command>:</para>
> +
> +<screen><userinput>sed -i "s;GPERF --version |;& head -n 1 |;" configure</userinput></screen>
> +

Would you place all the commands together in the area below and then place
the comments in the "Commands Explanations" section. It makes it so much
easier for folks to cut and paste. Additionally, that is how the majority
of the book is written.


>      <para>Install <application>a2ps</application> by running the following
>      commands:</para>
>  
> -<screen><userinput>sed -i 's/+0 -1/-k 1,2/' afm/make_fonts_map.sh &&
> -sed -i "s|/usr/local/share|/usr/share|" configure &&
> +<screen><userinput>sed -i "s;/usr/local/share;/usr/share;" configure &&

Why change the delimiter? Some editor before you felt "|" was better than
";". Not sure changing it is good here. :-)

-- 
Randy

rmlscsi: [bogomips 1003.24] [GNU ld version 2.16.1] [gcc (GCC) 4.0.3]
[GNU C Library stable release version 2.3.6] [Linux 2.6.14.3 i686]
08:36:00 up 15 days, 59 min, 1 user, load average: 0.30, 0.20, 0.07



More information about the blfs-book mailing list