r7583 - in trunk/bootscripts: . contrib contrib/lsb-v3 contrib/lsb-v3/blfs contrib/lsb-v3/blfs/init.d contrib/lsb-v3/sysconfig contrib/lsb-v3/sysconfig/network-devices contrib/lsb-v3/sysconfig/network-devices/services

Dan Nicholson dbn.lists at gmail.com
Sun Sep 7 10:17:22 PDT 2008


Nice, DJ. Some comments below.

On Sun, Sep 7, 2008 at 9:57 AM,  <dj at linuxfromscratch.org> wrote:
...
> Added: trunk/bootscripts/contrib/lsb-v3/blfs/init.d/alsa
> ===================================================================
> --- trunk/bootscripts/contrib/lsb-v3/blfs/init.d/alsa                           (rev 0)
> +++ trunk/bootscripts/contrib/lsb-v3/blfs/init.d/alsa   2008-09-07 16:57:38 UTC (rev 7583)
> @@ -0,0 +1,38 @@
> +#!/bin/sh
> +# Begin $rc_base/init.d/alsa
> +
> +### BEGIN INIT INFO
> +# Provides:            alsa
> +# Required-Start:
> +# Should-Start:
> +# Required-Stop:       $network
> +# Should-Stop:         $remote_fs

I don't think $network is really needed here. If someone has
$remote_fs, then it should take care of the network dependency. All we
really care is that /dev and /usr are still mounted. In that case, I
think $local_fs is probably required to ensure that /usr is still
there.

...
> Added: trunk/bootscripts/contrib/lsb-v3/blfs/init.d/cups
> ===================================================================
> --- trunk/bootscripts/contrib/lsb-v3/blfs/init.d/cups                           (rev 0)
> +++ trunk/bootscripts/contrib/lsb-v3/blfs/init.d/cups   2008-09-07 16:57:38 UTC (rev 7583)
> @@ -0,0 +1,60 @@
> +#!/bin/sh
> +# Begin /etc/init.d/cups
> +
> +### BEGIN INIT INFO
> +# Provides:            cups
> +# Required-Start:      $network
> +# Should-Start:        $remote_fs
> +# Required-Stop:       $network
> +# Should-Stop:         $remote_fs

Probably needs to require $local_fs to ensure /usr and /var (just to
be pedantic). That probably goes for most of the BLFS scripts since
they'll typically control daemons in /usr logging to /var.

...
> Added: trunk/bootscripts/contrib/lsb-v3/blfs/init.d/httpd
> ===================================================================
> --- trunk/bootscripts/contrib/lsb-v3/blfs/init.d/httpd                          (rev 0)
> +++ trunk/bootscripts/contrib/lsb-v3/blfs/init.d/httpd  2008-09-07 16:57:38 UTC (rev 7583)
> @@ -0,0 +1,57 @@
> +#!/bin/sh
> +# Begin /etc/init.d/httpd
> +
> +### BEGIN INIT INFO
> +# Provides:            httpd
> +# Required-Start:      $syslog $local_fs $network
> +# Should-Start:        $remote_fs
> +# Required-Stop:
> +# Should-Stop:

*-Stop should probably match *-Start.

...
> Added: trunk/bootscripts/contrib/lsb-v3/blfs/init.d/named
> ===================================================================
> --- trunk/bootscripts/contrib/lsb-v3/blfs/init.d/named                          (rev 0)
> +++ trunk/bootscripts/contrib/lsb-v3/blfs/init.d/named  2008-09-07 16:57:38 UTC (rev 7583)
> @@ -0,0 +1,62 @@
> +#!/bin/sh
> +# Begin /etc/init.d/named
> +
> +### BEGIN INIT INFO
> +# Provides:            named
> +# Required-Start:      $network
> +# Should-Start:
> +# Required-Stop:
> +# Should-Stop:         netfs

s/netfs/$remote_fs/
and should probably be in Should-Start.

I think I'll stop there for now.

--
Dan



More information about the blfs-book mailing list