cvs commit: ALFS/nALFS/src/handlers remove.c

Kevin P. Fleming kpfleming at linuxfromscratch.org
Fri Jan 30 14:21:44 PST 2004


Jamie Bennett wrote:

> I've been toying with what to do with the exiting of this function for 
> quite some
> time today. I understand your stance on goto's but to me it still seems 
> wrong to
> use them. As K&R said in their infamous book, 'everywhere a goto is used 
> can be
> replaced with a non-goto snippet of code' (guessing the wording as I 
> read it quite
> some hours ago).  I think a setting of status and a test at the end 
> fulfulls what I
> am trying to achieve. If your ok with this I will use a similar style 
> with <download>
> and <unpack> although these have goto's in them which you would want to 
> keep/not
> keep?

I have no problem with the way you changed remove.c, that looks fine. I 
don't think I'd want to see download/unpack converted back to the old 
style, there are many more exit points from those functions and it will 
add a lot of needless lines to the code to do it the other way.




More information about the alfs-log mailing list