Requested changes

Pierre Labastie pierre.labastie at neuf.fr
Thu Jan 23 01:14:44 PST 2014


Le 22/01/2014 06:42, Bruce Dubbs a écrit :
> Pierre Labastie wrote:
>> Le 21/01/2014 08:50, Bruce Dubbs a écrit :
>>> It does need a change.  In LFS/master.sh, the function do_housekeeping has:
>>>
>>>       @-if [ -h \$(MOUNT_PT)/dev/shm ]; then \\
>>>         link=\$\$(readlink \$(MOUNT_PT)/dev/shm); \\
>>>         umount \$(MOUNT_PT)/\$\$link; \\
>>>         unset link; \\
>>>       else \\
>>>         umount \$(MOUNT_PT)/dev/shm; \\
>>>       fi
>>>
>>> That can be changed to simply:
>>>
>>>       @-umount \$(MOUNT_PT)/run
>>>
>>> Here is my uncommitted diff:
>>>
>>> --- chapter09/reboot.xml        (revision 10447)
>>> +++ chapter09/reboot.xml        (working copy)
>>> @@ -87,16 +87,8 @@
>>>       <para>Then unmount the virtual file systems:</para>
>>>
>>>     <screen><userinput>umount -v $LFS/dev/pts
>>> -
>>> -if [ -h $LFS/dev/shm ]; then
>>> -  link=$(readlink $LFS/dev/shm)
>>> -  umount -v $LFS/$link
>>> -  unset link
>>> -else
>>> -  umount -v $LFS/dev/shm
>>> -fi
>>> -
>>>     umount -v $LFS/dev
>>> +umount -v $LFS/run
>>>     umount -v $LFS/proc
>>>     umount -v $LFS/sys</userinput></screen>
>>>
>>>      -- Bruce
>>>
>> I hope to do that tomorrow. Problem is that jhalfs should remain compatible
>> with former versions of the book, so I cannot just apply your patch, which
>> would try to umount a non mounted /run, wen using former versions of the books.
>> I'll try something like:
>> if mountpoint -q /run; then umount /run; else <old instructions>; fi
> That sound fine to me.
>
>     -- Bruce
>
Done at r3779
Pierre



More information about the alfs-discuss mailing list