Requested changes

Bruce Dubbs bruce.dubbs at gmail.com
Tue Jan 21 21:42:01 PST 2014


Pierre Labastie wrote:
> Le 21/01/2014 08:50, Bruce Dubbs a écrit :
>> Bruce Dubbs wrote:
>>> Pierre Labastie wrote:
>>>> Le 20/01/2014 15:47, Bruce Dubbs a écrit :
>>>>> Pierre,
>>>>>
>>>>> I have a couple of requests for enhancement of jhalfs.
>>>>>
>>>>> 1.  We are changing the book to mount /run as a tmpfs in Section 6.2,
>>>>> but I think jhalfs is not umounting it at the completion of the run.
>>>>> Can you check that?
>>>
>>>> I am following book modifications, but I was waiting for the changes
>>>> in chapter 09 "rebooting the system" to include them in jhalfs. My main
>>>> concern is that it looks like the logic for unmounting shm should be
>>>> changed too, and I do not know exactly what is to be done.
>>>
>>> OK.  I'll make that change.  jhalfs probably doesn't need any changes.
>>
>> It does need a change.  In LFS/master.sh, the function do_housekeeping has:
>>
>>      @-if [ -h \$(MOUNT_PT)/dev/shm ]; then \\
>>        link=\$\$(readlink \$(MOUNT_PT)/dev/shm); \\
>>        umount \$(MOUNT_PT)/\$\$link; \\
>>        unset link; \\
>>      else \\
>>        umount \$(MOUNT_PT)/dev/shm; \\
>>      fi
>>
>> That can be changed to simply:
>>
>>      @-umount \$(MOUNT_PT)/run
>>
>> Here is my uncommitted diff:
>>
>> --- chapter09/reboot.xml        (revision 10447)
>> +++ chapter09/reboot.xml        (working copy)
>> @@ -87,16 +87,8 @@
>>      <para>Then unmount the virtual file systems:</para>
>>
>>    <screen><userinput>umount -v $LFS/dev/pts
>> -
>> -if [ -h $LFS/dev/shm ]; then
>> -  link=$(readlink $LFS/dev/shm)
>> -  umount -v $LFS/$link
>> -  unset link
>> -else
>> -  umount -v $LFS/dev/shm
>> -fi
>> -
>>    umount -v $LFS/dev
>> +umount -v $LFS/run
>>    umount -v $LFS/proc
>>    umount -v $LFS/sys</userinput></screen>
>>
>>     -- Bruce
>>
>
> I hope to do that tomorrow. Problem is that jhalfs should remain compatible
> with former versions of the book, so I cannot just apply your patch, which
> would try to umount a non mounted /run, wen using former versions of the books.
> I'll try something like:
> if mountpoint -q /run; then umount /run; else <old instructions>; fi

That sound fine to me.

   -- Bruce




More information about the alfs-discuss mailing list