kbd-2.0.0 requires check

Pierre Labastie pierre.labastie at neuf.fr
Thu Sep 19 05:35:21 PDT 2013


Le 19/09/2013 13:27, Igor Živković a écrit :
> Hello,
>
> If running test suites is disabled, jhalfs won't build check which is
> now required for building kbd. I suppose LFS/master.sh should be
> modified:
>
>
> Index: LFS/master.sh
> ===================================================================
> --- LFS/master.sh       (revision 3720)
> +++ LFS/master.sh       (working copy)
> @@ -84,7 +84,6 @@
>          *tcl)       [[ "${TEST}" = "0" ]]&&  continue ;;
>          *expect)    [[ "${TEST}" = "0" ]]&&  continue ;;
>          *dejagnu)   [[ "${TEST}" = "0" ]]&&  continue ;;
> -      *check)     [[ "${TEST}" = "0" ]]&&  continue ;;
>          *stripping) [[ "${STRIP}" = "n" ]]&&  continue ;;
>          *glibc)     [[ "${TEST}" = "3" ]]&&  \
>                      sed -i 's@/usr/lib/locale@/tools/lib/locale@' $file
> ;;
>
Thinking a little more about it, I am not sure why tcl, expect, etc 
should not be built if test suites are disabled:
according to the book " Installing four packages for testing purposes 
may seem excessive, but it is very reassuring, if not essential, to know 
that the most important tools are working properly." So even if running 
the testsuites is not planned, I would be inclined to build those as a 
test of the toolchain. It adds an extra build time of 0.7 SBU or less, 
which is negligible anyway.

So I propose to suppress all 4 lines *tcl)...;; *expect)...;; etc.

Any thought?

Pierre



More information about the alfs-discuss mailing list