RFC: Remove GETKERNEL parameter

Pierre Labastie pierre.labastie at neuf.fr
Fri Feb 10 13:21:08 PST 2012


Le 10/02/2012 21:42, Matt Burgess a écrit :
> Hi all,
>
> The kernel package has been required since LFS-6.3.  LFS-6.2 was
> released 5.5 years ago, which was the last release when the kernel
> package wasn't required until chapter 8.  As such, the attached patch
> removes the ability to choose whether or not to download the kernel
> package.
>
> Regards,
>
> Matt.
Hi,

It is a good idea to remove this flag. I browsed quickly through
HLFS and CLFS books, and they all use linux kernel headers.

If I understand well, jhalfs should then behave as if GETKERNEL
were always set to 'y'. So I am not sure about this part:

Index: jhalfs-trunk/common/libs/func_download_pkgs
===================================================================
--- jhalfs-trunk.orig/common/libs/func_download_pkgs
+++ jhalfs-trunk/common/libs/func_download_pkgs
@@ -46,8 +46,7 @@ get_sources() {              # Download
              [[ "$VIMLANG" = "0" ]]&&  continue
            ;;
        *linux/linux-* )
-            [[ -z "$CONFIG" ]]&&  [[ -z "$BOOT_CONFIG" ]]&&  \
-            [[ "$GETKERNEL" = "n" ]]&&  continue
+            [[ -z "$CONFIG" ]]&&  [[ -z "$BOOT_CONFIG" ]]&&  continue
            ;;
      esac

----------------------------------------------
when GETKERNEL was equal to 'y' before, the continue statement
was never executed, while now, it will depend
on CONFIG and BOOT_CONFIG. Maybe I do not have the whole
picture, but it seems to me that the test should be completely suppressed.

Regards
Pierre



More information about the alfs-discuss mailing list