[patch] some fixes for common/libs/func_check_version.sh

Alexander E. Patrakov patrakov at gmail.com
Sun Nov 25 03:03:29 PST 2007


Csaba Henk wrote:
> Index: common/libs/func_check_version.sh
> ===================================================================
> --- common/libs/func_check_version.sh	(revision 3512)
> +++ common/libs/func_check_version.sh	(working copy)
> @@ -36,7 +36,7 @@
>  		    This script requires ${ref_version} or greater\n"
>     # Ask the user instead of bomb, to make happy that packages which version
>     # ouput don't follow our expectations
> -    echo "If you are sure that you have instaled a proper version of ${BOLD}$TXT${OFF}"
> +    echo "If you are sure that you have installed a proper version of ${BOLD}$TXT${OFF}"
>      echo "but jhalfs has failed to detect it, press 'c' and 'ENTER' keys to continue,"
>      echo -n "otherwise press 'ENTER' key to stop jhalfs.  "
>      read ANSWER
> @@ -84,7 +84,7 @@
>    libcVer="`/lib/libc.so.6 | head -n1`"
>    libcVer="${libcVer##*version }"
>    check_version "2.2.5"   ${libcVer%%,*}        "GLIBC"
> -  check_version "2.12"    "$(ld --version  | head -n1 | cut -d" " -f4)"        "BINUTILS"
> +  check_version "2.12"    "$(ld --version  | head -n1 | cut -d" " -f5)"        "BINUTILS"
>    check_version "1.15"    "$(tar --version | head -n1 | cut -d" " -f4)"        "TAR"
>    bzip2Ver="$(bzip2 --version 2>&1 < /dev/null | head -n1 | cut -d" " -f8)"
>    check_version "1.0.2"   "${bzip2Ver%%,*}"                                    "BZIP2"
> 

This fix is wrong on my Debian system:

$ ld --version  | head -n1 | cut -d" " -f5
for
$ GNU ld (GNU Binutils for Debian) 2.18

So we must invent a more robust way to capture the version string (maybe capture 
the last word?). See also http://wiki.linuxfromscratch.org/lfs/ticket/2111.

-- 
Alexander E. Patrakov




More information about the alfs-discuss mailing list