ABLFS20050909

Thomas Pegg thomasp at linuxfromscratch.org
Fri Sep 9 18:35:56 PDT 2005


On Fri, 2005-09-09 at 14:29 +0200, Filip Bartmann wrote:
> In appendix i send you patch from chapter 04-08 BLFS 6.1 to ABLFS SVN.Next patches I will send you after two weeks,because I have not internet connection for this time.
> Filip Bartmann
> 
First I don't want to discourage you from sending patches, but there
were several things wrong with this recent patch. Based on some of the
diffs I saw as I reviewed it, it seems as if your thinking the profile
should follow the book verbatim. This is partly correct, there are
however times where certain things are added or removed in order to
automate the build. 

Note: As I annotate, I'm removing the most of the content of the diffs
so I don't put the entire contents of the patch in this message.
diff -Naur BLFS/BLFS.xml BLFS_ch/BLFS.xml
--- BLFS/BLFS.xml       2005-09-07 12:38:22.000000000 +0200
+++ BLFS_ch/BLFS.xml    2005-09-09 15:51:47.000000000 +0200

Here you do half of a change to move libpcap to another directory, as it
should since it was moved to chapter16, but you only included the part
that removes it from chapter8. For a change like this you should have
both parts in the submitted not just the first half.

diff -Naur BLFS/config_standard/etc/nanorc
BLFS_ch/config_standard/etc/nanorc
--- BLFS/config_standard/etc/nanorc     2005-09-07 12:38:02.000000000
+0200
+++ BLFS_ch/config_standard/etc/nanorc  1970-01-01 01:00:00.000000000
+0100
This one is all wrong, you're removing a configuration file that is
installed for nano. Although in a later change you do remove the
installation of it, but that is wrong as well. Configuration sections in
the book are for the most part included in the profiles unless it's
something that really needs to be done manually. This diff will not be
applied. 

diff -Naur BLFS/config_standard/packages/ch04.ent
BLFS_ch/config_standard/packages/ch04.ent
--- BLFS/config_standard/packages/ch04.ent      2005-09-07
12:38:05.000000000 +0200
+++ BLFS_ch/config_standard/packages/ch04.ent   2005-09-09
16:17:57.000000000 +0200
 
 <!ENTITY cracklib-version   "2.8.3">
All change you made here for cracklib are wrong, the "," are no longer
in the package name or directory or even the patch files, it's dashes
now. Also you should not of changed the wordlist either. This portion
will not be applied.

+<!ENTITY mitkrb-package   "krb5-&mitkrb-version;-signed.tar">
This one should not have been changed, it should of remained as .tar.bz2
 
diff -Naur BLFS/chapter04/heimdal.xml BLFS_ch/chapter04/heimdal.xml
--- BLFS/chapter04/heimdal.xml  2005-09-07 12:38:15.000000000 +0200
+++ BLFS_ch/chapter04/heimdal.xml       2005-09-09 14:41:17.000000000 

+    <copy>
+      <source>doc/{init-creds,layman.asc}</source>
+      <destination>/usr/share/doc/heimdal-0.7</destination>
Please do not hardcode version numbers in the xml unless it's necessary,
here you could have used &heimdal-version; here as well as for the rest
of it too.
+    </copy>
+    <permissions mode="644">
+      <name>/usr/share/doc/heimdal-0.7/*</name>
+    </permissions>
This is unnecessary as, the umask is set to a sane value of 022 prior to
execution of nALFS. All testing that I've done proves that files are
installed with proper permissions without the need for modification of
them, except in those cases where they are corrected by the BLFS book. 
+    <permissions mode="755">
+      <name>/usr/share/doc/heimdal-0.7/standardisation</name>
+    </permissions>
Same thing as above.
+    <permissions mode="644">
+      <name>/usr/share/doc/heimdal-0.7/standardisation</name>
+    </permissions>
This one is unecessary as well for same reasons as stated above.


diff -Naur BLFS/chapter04/iptables.xml BLFS_ch/chapter04/iptables.xml
--- BLFS/chapter04/iptables.xml 2005-09-07 12:38:15.000000000 +0200
+++ BLFS_ch/chapter04/iptables.xml      2005-09-07 15:47:12.000000000
+0200
@@ -11,6 +11,9 @@
 %config_entities;
 %files;
 
+<!ENTITY bootscripts-get SYSTEM "../config/bootscripts_get.ent">
+<!ENTITY bootscripts-clean SYSTEM "../config/bootscripts_clean.ent">
+
 ]>
 <alfs>
   <package name="iptables" version="&iptables-version;">
@@ -37,16 +40,15 @@
         <param>install</param>
       </make>
     </stage>
-    <stage name="Configuring">
-      <!-- setup for personal firewall -->
-      <!-- other setups are available in the book -->
-      <copy base="&blfs-config;/etc/rc.d/init.d">
-       <source>firewall</source>
-       <source>firewall.status</source>
-       <source>firewall.stop</source>
-       <destination>/etc/rc.d/init.d</destination>
-      </copy> 
This portion above should have not been removed but adjusted to suit the
changes made in the firewalling section (mainly using only on file
called rc.iptables which is used by the bootscripts installed below.)
 
+    <stage name="Installing bootscript and configuration">


diff -Naur BLFS/chapter04/stunnel.xml BLFS_ch/chapter04/stunnel.xml
--- BLFS/chapter04/stunnel.xml  2005-09-07 12:38:15.000000000 +0200
+++ BLFS_ch/chapter04/stunnel.xml       2005-09-07 15:47:11.000000000
+020

-    </ownership><textdump>
-      <file>stunnel_answers</file>
-      <content>
-        =&stunnel-country;
-        =&stunnel-state;
-        =&stunnel-city;
-        =&stunnel-org;
-        =&stunnel-orgunit;
-        =&stunnel-host;
-      </content>
-    </textdump>
Here we have a problem, the above is necessary to automate the build of
stunnel, the fact you removed it tells me you did not test this to make
sure it worked, and most likely you've not installed stunnel before.

diff -Naur BLFS/chapter04/tripwire.xml BLFS_ch/chapter04/tripwire.xml
--- BLFS/chapter04/tripwire.xml 2005-09-07 12:38:15.000000000 +0200
+++ BLFS_ch/chapter04/tripwire.xml      2005-09-09 14:37:21.000000000 

       <execute command="twadmin">
         <param>--create-polfile</param>
        <param>--site-keyfile /etc/tripwire/site.key</param>
-        <param>-Q &tripwire-sitepassphrase;</param>
         <param>/etc/tripwire/&tripwire-policy-file;</param>
       </execute>
       <execute command="tripwire">
-        <param>-m i</param>
-        <param>-P &tripwire-localpassphrase;</param>
+        <param>-- init</param>
       </execute>
This changes definitely tell me you never tested this, if you had you
would realize that it would not work, without the parameters to pass the
passphrases to the commands executed you will find nALFS hanging waiting
for user input which is impossible since you cannot type anything in
like you could on the command line.

diff -Naur BLFS/chapter06/nano.xml BLFS_ch/chapter06/nano.xml
--- BLFS/chapter06/nano.xml     2005-09-07 12:38:16.000000000 +0200
+++ BLFS_ch/chapter06/nano.xml  2005-09-07 15:47:58.000000000 +0200
       </copy>
-    <copy>
-      <source>&blfs-config;/etc/nanorc</source>
-      <destination>/etc/nanorc</destination>
-    </copy>
This part should have not been removed the only thing that should of
changed was the destination from /etc to /etc/nano.

diff -Naur BLFS/chapter08/libusb.xml BLFS_ch/chapter08/libusb.xml
--- BLFS/chapter08/libusb.xml   2005-09-07 12:38:18.000000000 +0200
+++ BLFS_ch/chapter08/libusb.xml        2005-09-09 15:44:32.000000000
+0200
@@ -17,7 +17,7 @@
         <name>openjade</name>
       </utilizes>
       <utilizes>
-        <name>sgml-dtd31</name>
+        <name>sgml-dtd42</name>
       </utilizes>
       <utilizes>
        <name>doxygen</name>
diff -Naur BLFS/chapter08/pcre.xml BLFS_ch/chapter08/pcre.xml
--- BLFS/chapter08/pcre.xml     2005-09-07 12:38:18.000000000 +0200
+++ BLFS_ch/chapter08/pcre.xml  2005-09-07 15:48:47.000000000 +0200
@@ -44,6 +44,15 @@
        <source>doc/*.txt</source>
        <destination>/usr/share/doc/pcre-&pcre-version;</destination>
       </copy>
+      <move>
+       <source>/usr/lib/libpcre.so.*</source>
+       <destination>/lib/</destination>
+      </move>
+      <link>
+       <option>force</option>
+       <target>../../lib/libpcre.so.0</target>
+       <name>/usr/lib/libpcre.so</name>
+      </link>
These are only necessary if grep is reinstalled and is linked against
the pcre library, this should be an optional section that is commented
out by default.

diff -Naur BLFS/wget/chapter04.urls BLFS_ch/wget/chapter04.urls
--- BLFS/wget/chapter04.urls    2005-09-07 12:38:22.000000000 +0200
+++ BLFS_ch/wget/chapter04.urls 2005-09-09 14:46:22.000000000 +0200
@@ -1,29 +1,27 @@

+ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/A-C/cracklib/cracklib-2.8.3.tar.bz2
+ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/A-C/cracklib/cracklib-2.8.3-heimdal-1.patch
+ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/A-C/cracklib/allwords.bz2
Don't know where this came from there is no cracklib subdirectory on
lfs-matrix.net.

 
 ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/L/Linux-PAM-0.80.tar.bz2
-ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/L/Linux-PAM-0.80-docs.tar.bz2
Wrong, the docs tarball is needed to install the documentation for
Linux-PAM.
 
 ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/Q-S/shadow-4.0.9.tar.bz2
-ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/Q-S/shadow-4.0.9-Linux_PAM_fixes-1.patch
+ftp://ftp.lfs-matrix.net/pub/BLFS/SVN/Q-S/shadow-4.0.9-fix_lastlog-1.patch
Incorrect here too, one the lastlog patch is not longer necessary with
4.0.9, and the Linux_PAM_fixes patch is required to build shadow against
Linux_PAM.
 
I hope after all this I haven't discouraged you from sending future
patches, but please keep in mind some of the things I have mentioned for
the future.

--
Thomas
LFS User : 4729 / Linux User : 298329
kitt - Powered by: Linux 2.6.11-gentoo-r7
19:50:19 up 22 days, 20 min, 2 users, load average: 1.19, 0.40, 0.20

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.linuxfromscratch.org/pipermail/alfs-discuss/attachments/20050909/f0b18892/attachment.sig>


More information about the alfs-discuss mailing list