more updates

Neven Has haski at sezampro.yu
Sun Jan 7 08:12:01 PST 2001


On Sun, Jan 07, 2001 at 07:45:37AM +0000, Bryan Dumm wrote:
> You will find everything in CVS, also I started a Credits, License
> file that needs fleshed out.

I'll just reply to your comments here so you can delete them.
I did some changes/fixes, but I'm not going to send any code here again, I'll 
wait for Jesse to open that CVS account for me, it'll be much easier.

Neven

-------------- next part --------------
--- alfs-orig	Sun Jan  7 16:51:48 2001
+++ alfs	Sun Jan  7 17:05:10 2001
@@ -250,6 +250,10 @@
 	my $mpoint = fix_text($elt->text);
 
 #why?	print "DISABLED: ";
+
+# NH: When testing the backend I use "/tmp/lfs" for &LFS; and don't do any
+# mounting. So it's just me. :) Ignore it.
+
 	print "mount -t $type $device $mpoint\n";
 	return if (! &to_continue);
 	system_return(system "mount -t $type $device $mpoint");
@@ -280,6 +284,13 @@
 	#	return if error("Unable to symlink.\n");
 	#}
 
+        # NH: Well, for example for:
+        #       <copy source="g*zip" dir="&LFS;/usr/bin">&LFS;/bin</copy>
+        # and not just for <link>.
+        # There are more places where this could be added, but I'm not sure
+        # if it's a good idea.
+
+        # NH: Why not error() below: /me forgot to add it.
 
 	$source = join("", glob($source));
 
@@ -341,6 +352,14 @@
 	#	}
 	#}
 
+        # NH: For those elements no, since you added <mkdir> for "gcc-build",
+        # and possibly others (which is a good idea BTW).
+
+        # But here, for <system_command>, we should decide if the directory
+        # ("dir" attribute) should be created, or should we exit (or whatever)
+        # with an error if it does not exist already.
+        # IMHO, that should be an error. But maybe not?
+
 	if (! chdir $dir) {
 		return if error("Unable to change directory to $dir.\n");
 	}
@@ -376,12 +395,17 @@
 
         #BD: What does adding tar xf - instead do for us?
 
+        # NH: Nothing. This is just fine.
+
 		system_return(system "bzcat $archive | tar x");
 
 	} elsif ($archive =~ /\.gz$/) {
 		system_return(system "gunzip $archive");
 		
                 # BD: Shouldn't \Q and \E be added below?
+
+                # NH: Why? There are no "problematic" characters/variables in 
+                # there. Just ".gz" to be removed.
 
                 $archive =~ s/\.gz//;
 		copy ($archive, $destination) 


More information about the alfs-discuss mailing list